Merge branch 'master' into contributing-guide

aws · May 14, 2021 · 40b3b3a · 40b3b3a
2 parents 3d700d6 + 348e11e
commit 40b3b3a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/packages/@aws-cdk/aws-ecs/lib/base/base-service.ts b/packages/@aws-cdk/aws-ecs/lib/base/base-service.ts
@@ -415,6 +415,8 @@ export abstract class BaseService extends Resource
     if (props.cloudMapOptions) {
       this.enableCloudMap(props.cloudMapOptions);
     }
+
+    this.node.defaultChild = this.resource;
   }
 
   /**

diff --git a/packages/@aws-cdk/aws-ecs/test/ec2/ec2-service.test.ts b/packages/@aws-cdk/aws-ecs/test/ec2/ec2-service.test.ts
@@ -25,7 +25,7 @@ nodeunitShim({
         memoryLimitMiB: 512,
       });
 
-      new ecs.Ec2Service(stack, 'Ec2Service', {
+      const service = new ecs.Ec2Service(stack, 'Ec2Service', {
         cluster,
         taskDefinition,
       });
@@ -47,6 +47,8 @@ nodeunitShim({
         EnableECSManagedTags: false,
       }));
 
+      test.notEqual(service.node.defaultChild, undefined);
+
       test.done();
     },
 

diff --git a/packages/@aws-cdk/aws-ecs/test/fargate/fargate-service.test.ts b/packages/@aws-cdk/aws-ecs/test/fargate/fargate-service.test.ts
@@ -23,7 +23,7 @@ nodeunitShim({
         image: ecs.ContainerImage.fromRegistry('amazon/amazon-ecs-sample'),
       });
 
-      new ecs.FargateService(stack, 'FargateService', {
+      const service = new ecs.FargateService(stack, 'FargateService', {
         cluster,
         taskDefinition,
       });
@@ -79,6 +79,8 @@ nodeunitShim({
         },
       }));
 
+      test.notEqual(service.node.defaultChild, undefined);
+
       test.done();
     },