Skip to content

Commit

Permalink
fix(route53): CrossAccountZoneDelegationRecord is still using Node …
Browse files Browse the repository at this point in the history
…16 (#26980)

Updates the `CrossAccountZoneDelegationRecord` construct to use sdk v3 / node 18. 

This is identical to changes in #26212, except for hardcoding a region into the `assumeRole` sdk call. This may not be the ideal solution, but should not break specific configurations.

That specific configuration, as #26593 pointed out, was that the original update was a breaking change if the construct was deployed into an opt-in region, and the parent zone did not have that opt-in region enabled.

This PR removes the semi-hidden `@aws-cdk/aws-route53:useRegionalStsEndpoint` feature flag, as it was based on a confusion on why things used to work. We now pick the correct endpoint manually.

Closes #26976.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
scanlonp authored and Mike Wrighton committed Sep 14, 2023
1 parent 611f66f commit 5eb4e18
Show file tree
Hide file tree
Showing 19 changed files with 1,142 additions and 1,031 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5eb4e18

Please sign in to comment.