Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ecs): specify the Firelens container image version #16733

Closed
2 tasks
tai-acall opened this issue Sep 30, 2021 · 3 comments
Closed
2 tasks

(ecs): specify the Firelens container image version #16733

tai-acall opened this issue Sep 30, 2021 · 3 comments
Assignees
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@tai-acall
Copy link

tai-acall commented Sep 30, 2021

I hope to specific which version of the fluent-bit image I use but I couldn't find any options to do this.

Use Case

A DNS Resolver bug inside the Fluent Bit v1.8.3 breaks function for transferring logs from ECS(Fargate) to the Datadog.

the only way to resolve this is specific which fluent-bit image version I use to, but I can not find any options to do this in CDK.

more detail about this issue.
aws/aws-for-fluent-bit#233

the following version of fluent-bit should be fine.
public.ecr.aws/aws-observability/aws-for-fluent-bit:2.19.0

Proposed Solution

Add an option to specific fluent-bit image url.

Other

fluent/fluent-bit#4050

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@tai-acall tai-acall added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 30, 2021
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Sep 30, 2021
@tai-acall
Copy link
Author

I notice that the fluent-bit image set as latest, setting as stable might be better.

aws/aws-for-fluent-bit#233 (comment)

@peterwoodworth peterwoodworth changed the title (class LogDrivers): specific the Firelens container image version (ecs): specific the Firelens container image version Sep 30, 2021
@peterwoodworth peterwoodworth removed the @aws-cdk/aws-appsync Related to AWS AppSync label Sep 30, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Sep 30, 2021
@peterwoodworth peterwoodworth added p1 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 30, 2021
@peterwoodworth peterwoodworth changed the title (ecs): specific the Firelens container image version (ecs): specify the Firelens container image version Sep 30, 2021
@peterwoodworth
Copy link
Contributor

Thanks for reporting this issue @tai-acall

The root of the issue has already been reported and there's a PR open to fix the issue. This PR changes the default from latest to stable

I'll make sure our SDEs take a look at the PR. I'm going to close this issue in favor of #16403, so please go there for any further updates :)

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

4 participants