fix(ecs): default to stable fluentbit image #16439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
blimmer
force-pushed
the
blimmer/default-fluentbit-to-stable
branch
from
fc6300e
to
1b8bd1a
Compare
blimmer
force-pushed
the
blimmer/default-fluentbit-to-stable
branch
from
1b8bd1a
to
1ea19a3
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
👏 |
RomainMuller
force-pushed
the
master
branch
from
924c117
to
ebfd5f2
Compare
2 tasks
peterwoodworth
changed the title
github-actions
bot
added
the
@aws-cdk/aws-ecs
rix0rrr
added
feature-request
madeline-k
reviewed
Mar 23, 2022
|
Closing this PR, since the upstream issue with fluentbit has been resolved. And, if customers do not want to use the default image tag of 'latest', they can pass in the image tag using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, due to an upstream issue with fluentbit,
amazon/aws-for-fluent-bit:latestis completely broken for folks who forward logs to aggregators like Datadog.There's currently an open issue (aws/aws-for-fluent-bit#233) about the upstream DNS problem in fluentbit.
As referenced in the
aws-for-fluent-bitdocumentation, AWS retains astableversion tag that is validated to be free from major bugs like this one:Therefore, this PR updates the default
imageTagfromlatesttostable. This technically could be considered a breaking change but, because the currentlatesttag is considerably broken, I think it might make sense to push this change out sooner than later.See also #16403 where this issue is discussed.
fixes: #16403
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license