Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@aws-cdk/aws-amplify-alpha module: Add performance mode option #18557

Closed
2 tasks
AndyW22 opened this issue Jan 20, 2022 · 1 comment · Fixed by #18598
Closed
2 tasks

@aws-cdk/aws-amplify-alpha module: Add performance mode option #18557

AndyW22 opened this issue Jan 20, 2022 · 1 comment · Fixed by #18598
Assignees
@skinny85
Labels
@aws-cdk/aws-amplify Related to AWS Amplify feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@AndyW22
Copy link

AndyW22 commented Jan 20, 2022 •
edited
Loading

Description

On the amplify console, there is a "performance mode" option on each branch, this is not present in CDK.

image

Use Case

Performance mode is useful with cache policies for the cloudfront distribution and should be an option for each branch.

Proposed Solution

performanceMode added to the BranchOptions interface with the existing autoBuild option:

    const master = amplifyApp.addBranch('master', {
     autoBuild: true,
     performanceMode: true
});

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@AndyW22 AndyW22 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 20, 2022
@github-actions github-actions bot added the @aws-cdk/aws-amplify Related to AWS Amplify label Jan 20, 2022
@jumic jumic mentioned this issue Jan 21, 2022
Merged
@mergify mergify bot closed this as completed in #18598 Feb 2, 2022
mergify bot pushed a commit that referenced this issue Feb 2, 2022
@jumic
feat(amplify): support performance mode in Branch (#18598)
bdeb8eb 
Add support for [performance mode](https://docs.aws.amazon.com/amplify/latest/userguide/ttl.html#Performance-mode
) in Amplify branches.

Performance mode optimizes for faster hosting performance by keeping content cached at the edge for a longer interval.

Closes #18557.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@jumic @TikiTDO
feat(amplify): support performance mode in Branch (aws#18598)
673f914 
Add support for [performance mode](https://docs.aws.amazon.com/amplify/latest/userguide/ttl.html#Performance-mode
) in Amplify branches.

Performance mode optimizes for faster hosting performance by keeping content cached at the edge for a longer interval.

Closes aws#18557.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-amplify Related to AWS Amplify feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(amplify): support performance mode in Branch jumic/aws-cdk
2 participants
@skinny85 @AndyW22