aws-appsync: Data Source name does not handle tokens appropriately

[saltman424]

What is the problem?

This line mutates Tokens so that they do not get resolved:

aws-cdk/packages/@aws-cdk/aws-appsync/lib/data-source.ts

Line 115 in 9975ec8

const name = (props.name ?? id).replace(/[\W]+/g, '');

Reproduction Steps

new appsync.NoneDataSource(scope, 'DataSource', {
  api,
  name: `My${cdk.Lazy.string({ produce(): string { return 'Prod' }})}DataSource`
})

What did you expect to happen?

Data Source name = 'MyProdDataSource'

What actually happened?

Data Source name = 'MyTokenTOKEN1234DataSource'

CDK CLI Version

2.11.0

Framework Version

2.11.0

Node.js Version

16.13.1

OS

Microsoft Windows 10 Enterprise

Language

Typescript

Language Version

4.5.5

Other information

This is the cause: bb8d6f6

Possible solutions:

• Use more sophisticated special character removal logic that identifies tokens and leaves their necessary special characters
• Check if name isUnresolved and don't apply special character removal if it is
• Only use special character removal if using the id as the name so that when developers pass an explicit name it is used exactly as-is, and if it has invalid characters, they'll get an error during deployment
• Similar to the above option, but add logic to determine if an explicitly passed name contains special characters outside of tokens and throw an error during synthesis rather than deployment

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.