servicecatalogappregistry: Use cdk.App as scope for TargetApplication application

[alexpulver]

Describe the feature

Use stackId prop value verbatim in TargetApplication class, with no prefix.

Update the stackId prop description to align with the definition in Identifiers documentation:
“The id of a stack is also the identifier that you use to refer to it in the AWS CDK Toolkit (cdk command).”

Use Case

As a user, I want to have full control over the stack ID, to maintain a naming convention when using AWS CDK Toolkit. AWS CDK Construct Library v2.51.0 allows to set the stack ID for TargetApplication, but prefixes the name with the containing construct ID, which I think it shouldn’t.

For an example, the following example code snippet:

application = appregistry_alpha.TargetApplication.create_application_stack(
    application_name=constants.APP_NAME,
    stack_id=constants.APP_NAME + "AppRegistryApplication",
    env=cdk.Environment(
        account=APPREGISTRY_APPLICATION_ACCOUNT,
        region=APPREGISTRY_APPLICATION_REGION,
    ),
)
appregistry_application_associator = appregistry_alpha.ApplicationAssociator(
    app, "AppRegistryApplicationAssociator", applications=[application]
)

Produces the following stack ID for the AppRegistry application (I define the other stacks elsewhere):

Supply a stack id (AppRegistryApplicationAssociator/UserManagementBackendAppRegistryApplication, UserManagementBackendSandbox, UserManagementBackendToolchain) to display its template. 

I expected the behavior to be:

Supply a stack id (UserManagementBackendAppRegistryApplication, UserManagementBackendSandbox, UserManagementBackendToolchain) to display its template. 

Proposed Solution

Update this to scope in

aws-cdk/packages/@aws-cdk/aws-servicecatalogappregistry/lib/application-associator.ts

Line 45 in 2c61405

this.application = targetApplication.bind(this).application;

(thanks @rohitagg0807!)

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.51.0

Environment details (OS name and version, etc.)

macOS Monterey 12.6.1

[peterwoodworth]

Thanks @rohitagg0807 for the PR.

I'm not certain if this is a direction we'll want to take, but I can see the reasoning. If we do want to take this direction, we'll be able to make this change even though it's breaking as the module not yet considered stable

[rohitagg0807]

Yes this is the direction we want to take and move forward.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[alexpulver]

@rohitagg0807 thank you! It looks much better now from user experience perspective 😄