awsstepfunctions|awsstepfunctionstasks: Allow custom state names

[jerrydevin96]

Describe the feature

We use the go bindings for AWS CDK (https://github.com/aws/aws-cdk-go) to deploy state machines. The functions provided to create a state machine in the library do not have the option to add a custom state name, which is possible while creating a state machine from the console. instead while using the CDK, the state name is auto-generated from other inputs provided while defining the state machine. This auto-generated state name is too long and confusing.

Use Case

Too long state names are confusing. Having the possibility to add a custom user-defined state name would be really good.

Proposed Solution

Add additional struct field to define custom state names.

Other Information

I am raising this issue here, as the Go Bindings (https://github.com/aws/aws-cdk-go) do not have issues enabled.

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.49.1

Environment details (OS name and version, etc.)

macOS v12.5.1

[rix0rrr]

It should be simple enough to add a stateName property to every state. Some care should be taken for using the same StateMachineFragment multiple times though.

[jerrydevin96]

Will this have to be implemented in the current repository (https://github.com/aws/aws-cdk) or should it be implemented in the go bindings (https://github.com/aws/aws-cdk-go) repository?

[Jacco]

I do not understand the issue raised here. Looking at the code it seems to me that everywhere the logical id of the State construct is used as the name of the State in the rendered JSON.

[jerrydevin96]

@Jacco yeah, you are right in saying that. The logical id which uniquely identifies what is being deployed through CDK is also used as the name of the state.

The problem is that we are using CDK in an application that will be using 40+ lambdas. Considering the application size and our architecture we follow a hierarchical naming structure for each logical id (eg. in case we are invoking a lambda as part of a state machine, the reference logical id could be something like appname-lambdaname-lambda-invoke). When the same logical ID is used as a state name, sometimes the length exceeds 80 characters and AWS doesn't allow state names over 80 chars long. Also having very long state names is confusing when viewing the state machine on the console.

We are following a hierarchical naming pattern for the logical id because it needs to be unique for every resource created by CDK.

Sorry for the late reply!

[bun913]

Hello!
May I challenge this issue?

[bun913]

I was going to start working on this Issue, but as per the following comment, I reconsidered whether it is a problem on the naming convention side.

#23532 (comment)

I was going to start working on this issue, but then I reconsidered and wondered if it would be possible to write the logic on the naming side so that it would not be too long.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.