Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotswap + AppSync: Support for Hotswapping AppSync Schemas #24113

Open
2 tasks
alharris-at opened this issue Feb 10, 2023 · 1 comment
Open
2 tasks

Hotswap + AppSync: Support for Hotswapping AppSync Schemas #24113

alharris-at opened this issue Feb 10, 2023 · 1 comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync feature-request A feature should be added or improved. p3

Comments

@alharris-at
Copy link

alharris-at commented Feb 10, 2023 •
edited
Loading

Describe the feature

Today, AppSync users have some limited hotswap capabilities in terms of updating Resolver and Function code, but they cannot update their GraphQL Schema, which I'd contend is the other most commonly iterated on part of an API.

I'd like to propose adding a new Hotswap for GraphQL Schema which will leverage the StartSchemaCreationCommand, and add a poller for the GetSchemaCreationStatusCommand with some upper-bound timeout (e.g. 30s).

This should allow iteration on more happy-case changes without needing to fallback to a full deploy, and hopefully take trivial schema changes (e.g. adding a field to a type) from ~100 seconds today to ~10 seconds as is seen w/ other hotswapped resources.

Use Case

I've written up a series of feature requests which I think will add to a faster, more fluid experience for AppSync users:

Proposed Solution

Add Hotswap for AppSyncGraphQLSchema resources.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.64.0

Environment details (OS name and version, etc.)

osx 13.2
@alharris-at alharris-at added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 10, 2023
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Feb 10, 2023
This was referenced Feb 10, 2023
Open
Open
@pahud
Copy link
Contributor

pahud commented Feb 16, 2023

Thank you for your feature request. I am making them as p2 and will raise the awareness to the team.

@pahud pahud added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2023
@Amplifiyer Amplifiyer mentioned this issue Sep 19, 2023
Merged
mergify bot pushed a commit that referenced this issue Sep 28, 2023
@Amplifiyer
feat(cdk): add AppSync GraphQLSchema and pipeline resolvers as hot sw…
0ea6313 
…appable (#27197)

1. Add GraphQLSchema as another AppSync resource that can be hotswapped
2. For all AppSync resources, accept the change in S3 assets/files instead of just inline code as a candidate for hotswap
3. Make pipeline resolvers hotswappable by resolving the functionId of AppSync functions.

Closes #2659, #24112, #24113.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-appsync Related to AWS AppSync feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pahud @alharris-at