Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synthetics: cdk requires handler to end in .handler when synthetics do not #26540

Closed
kaizencc opened this issue Jul 27, 2023 · 1 comment · Fixed by #26569
Closed

synthetics: cdk requires handler to end in .handler when synthetics do not #26540

kaizencc opened this issue Jul 27, 2023 · 1 comment · Fixed by #26569
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@kaizencc
Copy link
Contributor

Describe the bug

From the docs:

The entry point to use for the source code when running the canary. For canaries that use the syn-python-selenium-1.0 runtime or a syn-nodejs.puppeteer runtime earlier than syn-nodejs.puppeteer-3.4, the handler must be specified as fileName.handler. For syn-python-selenium-1.1, syn-nodejs.puppeteer-3.4, and later runtimes, the handler can be specified as fileName.functionName , or you can specify a folder where canary scripts reside as folder/fileName.functionName .

Currently CDK enforces that the handler is named filename.handler for all runtimes, which is too strict.

Expected Behavior

CDK enforces what Synthetics enforces

Current Behavior

CDK enforces legacy rules.

Reproduction Steps

n/a

Possible Solution

Removing the synth-time check that enforces this rule.

Additional Information/Context

No response

CDK CLI Version

latest

Framework Version

No response

Node.js Version

latest

OS

latest

Language

Typescript

Language Version

No response

Other information

No response
@kaizencc kaizencc added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 27, 2023
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Jul 27, 2023
@kaizencc kaizencc added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 27, 2023
@lpizzinidev lpizzinidev mentioned this issue Jul 29, 2023
Merged
@github-actions github-actions bot mentioned this issue Aug 1, 2023
Closed
lpizzinidev added a commit to lpizzinidev/aws-cdk that referenced this issue Aug 2, 2023
@lpizzinidev
Merge branch 'main' into awsgh-26540
dfa4e47
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Aug 2, 2023
@mergify
Merge branch 'main' into awsgh-26540
fad31f9
@mergify mergify bot closed this as completed in #26569 Aug 2, 2023
mergify bot pushed a commit that referenced this issue Aug 2, 2023
@lpizzinidev
fix(synthetics): updated handler validation (#26569)
1eaec92 
This fix updates handler validation based on Synthetic rules for [Node](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_WritingCanary_Nodejs.html#:~:text=and%20files.-,Handler%20name,-Be%20sure%20to) and [Python](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_WritingCanary_Python.html#:~:text=Packaging%20your%20canary%20files) runtimes.

Closes #26540.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(synthetics): updated handler validation lpizzinidev/aws-cdk
1 participant
@kaizencc