Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lambda Insights has incorrect ARN for 1.0.229 in us-west-1 on ARM64 #26615

Closed
chuanconggao opened this issue Aug 3, 2023 · 5 comments · Fixed by #26626
Closed

Lambda Insights has incorrect ARN for 1.0.229 in us-west-1 on ARM64 #26615

chuanconggao opened this issue Aug 3, 2023 · 5 comments · Fixed by #26626
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1

Comments

@chuanconggao
Copy link

Describe the bug

In public doc and CDK, it mentions Lambda layer ARN of version 5 for 1.0.229 in us-west-1 on ARM64
arn:aws:lambda:us-west-1:580247275435:layer:LambdaInsightsExtension-Arm64:5

However, I am getting CFN error like below only in us-west-1

... is not authorized to perform: lambda:GetLayerVersion on resource: arn:aws:lambda:us-west-1:580247275435:layer:LambdaInsightsExtension-Arm64:5 because no resource-based policy allows the lambda:GetLayerVersion action ...

It seems version 5 actually does not exist, and only version 3 exists in us-west-1 on ARM64, based on verification in Lambda console.

Expected Behavior

Able to use Lambda Insights 1.0.229 in us-west-1 on ARM64

Current Behavior

Not able to deploy

Reproduction Steps

As mentioned above

Possible Solution

Either fix Lambda layer ARN to version 3 or actually upgrade to version 5

Additional Information/Context

No response

CDK CLI Version

2.88

Framework Version

No response

Node.js Version

18

OS

macOS

Language

Typescript

Language Version

No response

Other information

No response
@chuanconggao chuanconggao added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 3, 2023
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Aug 3, 2023
@chuanconggao
Copy link
Author

I have confirmed with Lambda Insights folks and confirmed the version is wrong. They are updating on their side, and CDK side should update as well.

@pahud pahud self-assigned this Aug 3, 2023
@pahud
Copy link
Contributor

pahud commented Aug 3, 2023

yes we should fix here

https://github.com/aws/aws-cdk/blob/03c6f6fb667a1d7034537b514103215bb949a8da/packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts#L230C41-L230C41

Would you like to submit a PR for that?

@pahud pahud removed their assignment Aug 3, 2023
@pahud pahud added good first issue Related to contributions. See CONTRIBUTING.md p1 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 3, 2023
@khushail khushail mentioned this issue Aug 3, 2023
Merged
@mergify mergify bot closed this as completed in #26626 Aug 7, 2023
mergify bot pushed a commit that referenced this issue Aug 7, 2023
@khushail
fix(lambda): Lambda Insights Layer ARN 1.0.229 in us-west-1 on ARM64 …
dabf868 
…incorrect (#26626)

Existing [documentation](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Lambda-Insights-extension-versionsARM.html#Lambda-Insights-extension-ARM-1.0.229.0)

Closes #26615 .



----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@orekav
Copy link
Contributor

orekav commented Aug 11, 2023

I have checked against Google cached website and yes, it was wrong before.
I put the previous PR up #26150

Wouldn't be better to have an actual test that deploys a lambda in each region with every layer in the fact_table?
Or is it an overkill?

https://webcache.googleusercontent.com/search?q=cache:pLFJLErl5FcJ:https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Lambda-Insights-extension-versionsARM.html&cd=8&hl=en&ct=clnk&gl=uk

@chuanconggao
Copy link
Author

Integ tests against all regions and different combinations should be there, especially for this case where there are so many hardcoded values different across regions.

@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lambda): Lambda Insights Layer ARN 1.0.229 in us-west-1 on ARM64 incorrect aws/aws-cdk
3 participants
@pahud @chuanconggao @orekav