Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-synthetics-alpha): Node 16 End Of Life #27337

Closed
1 of 2 tasks
Abdu03 opened this issue Sep 28, 2023 · 3 comments · Fixed by #27339
Closed
1 of 2 tasks

(aws-synthetics-alpha): Node 16 End Of Life #27337

Abdu03 opened this issue Sep 28, 2023 · 3 comments · Fixed by #27339
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. node18-upgrade Any work (bug, feature) related to Node 18 upgrade p2

Comments

@Abdu03
Copy link
Contributor

Abdu03 commented Sep 28, 2023 •
edited
Loading

Describe the feature

Opeing new issue (duplicate of previously closed issue) now that syn-nodejs-puppeteer-6.0 has been released.

Node 16 is EOL. Cloudwatch Synthetics should be able to utilise the next supported runtime (node 18), ideally before the EOL.

Use Case

Cloudwatch Synthetic Lambda's should have the ability to use the Node 18 runtime... so that AWS clients can keep up to date with the later NodeJS software releases and stay on a supported version.

Proposed Solution

Create a new SYNTHETICS_NODEJS runtime running on the newly configured syn-nodejs-puppeteer v6.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.83.0

Environment details (OS name and version, etc.)

n/a
@Abdu03 Abdu03 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 28, 2023
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Sep 28, 2023
@Abdu03 Abdu03 changed the title (aws-synthetics-alpha): Node 16 Approaching End Of Life (aws-synthetics-alpha): Node 16 End Of Life Sep 28, 2023
@Abdu03 Abdu03 mentioned this issue Sep 28, 2023
Merged
@khushail khushail added p2 effort/small Small work item – less than a day of effort node18-upgrade Any work (bug, feature) related to Node 18 upgrade and removed needs-triage This issue or PR still needs to be triaged. labels Sep 28, 2023
@khushail
Copy link
Contributor

Thanks @Abdu03 for keeping a track and submitting the PR.

@Abdu03
Copy link
Contributor Author

Abdu03 commented Sep 28, 2023 •
edited
Loading

Thanks @Abdu03 for keeping a track and submitting the PR.

No problem 😄 the build is failing on the PR (not entirely sure why tbh), and the linter is asking for integration tests.

it is nearing EOD where i am, so i am probably going to leave it for today and have another look tomorrow (unless someone else can figure out whats wrong before me 👀 )

@mergify mergify bot closed this as completed in #27339 Sep 29, 2023
mergify bot pushed a commit that referenced this issue Sep 29, 2023
@Abdu03
feat(synthetics): CloudWatch Synthetics NodeJS Pupeteer 6.0 Runtime w…
e48af04 
…ith NodeJS 18 (#27339)

Added `syn-nodejs-puppeteer-6.0` version to avaiable synthetic runtimes.
This version runs on Node 18 allowing users to move away from node 16 (which is now at EOL).

Changed an exisiting test to refrence the latest runtime and also updated the examples in the readme to refrence the latest runtime.

Closes #27337.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. node18-upgrade Any work (bug, feature) related to Node 18 upgrade p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(synthetics): CloudWatch Synthetics NodeJS Pupeteer 6.0 Runtime with NodeJS 18 Abdu03/aws-cdk
2 participants
@Abdu03 @khushail