Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ec2: Support for P5 InstanceClass #27704

Closed
1 of 2 tasks
niroam opened this issue Oct 26, 2023 · 2 comments · Fixed by #27705
Closed
1 of 2 tasks

aws_ec2: Support for P5 InstanceClass #27704

niroam opened this issue Oct 26, 2023 · 2 comments · Fixed by #27705
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@niroam
Copy link
Contributor

niroam commented Oct 26, 2023

Describe the feature

The P5 Instance type is now GA, but not currently supported as part of the InstanceClass Enum

Use Case

P5 instances used in Batch pipelines for ML / Inference workloads, Creating the Batch piplines in CDK requires additional effort without the InstanceClass enum available

Proposed Solution

Add the missing types to the list.

Other Information

https://aws.amazon.com/ec2/instance-types/p5/

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.103.0 (build d0d7547)

Environment details (OS name and version, etc.)

MacOS
@niroam niroam added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 26, 2023
@niroam niroam mentioned this issue Oct 26, 2023
Merged
@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 27, 2023
@khushail
Copy link
Contributor

thanks @niroam for this FR and submittng PR as well.

@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@mergify mergify bot closed this as completed in #27705 Nov 2, 2023
mergify bot pushed a commit that referenced this issue Nov 2, 2023
@niroam
feat(ec2): Add support for P5 instances EC2 (#27705)
c3357ad 
The P5 instance types were introduced in [July 2023](https://aws.amazon.com/blogs/aws/new-amazon-ec2-p5-instances-powered-by-nvidia-h100-tensor-core-gpus-for-accelerating-generative-ai-and-hpc-applications/).
The instance types are supported in [CloudFormation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-instance.html#cfn-ec2-instance-instancetype).


Closes #27704.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ec2): Add support for P5 instances EC2 niroam/aws-cdk
2 participants
@niroam @khushail