Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ecs-patterns): Integration testing of aws-ecs-patterns contains an invalid integration test #28383

Closed
AnuragMohapatra opened this issue Dec 15, 2023 · 2 comments · Fixed by #28463
Closed

(aws-ecs-patterns): Integration testing of aws-ecs-patterns contains an invalid integration test #28383

AnuragMohapatra opened this issue Dec 15, 2023 · 2 comments · Fixed by #28463
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@AnuragMohapatra
Copy link
Contributor

Describe the bug

The integration testing of the aws-ecs-patterns has an invalid docker being used,

  1. When executed the container state always fails with the following message -
    image

  2. Looking at the docker and python file it never creates a webserver so the test on this location(

    aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.queue-processing-fargate-service-public.ts

    Line 18 in 7c62d68

    command: ['CMD-SHELL', 'curl -f http://localhost/ || exit 1'],
    ) ideally should always fail as it asks the container to either respond with a localhost response which is not possible as there is no web server building in the docker image or give exit 1 which is exit with failure.

  3. It is possible there are other issues with the integration testing but I have found these while working on the bug - aws-ecs-patterns (QueueProcessingFargateService): non-editable Scaling Policy causes race conditions & dropped tasks #20706

Expected Behavior

All integration tests should be perfectly aligned and work as expected.

Current Behavior

Integration tests go into infinite loop until cloud formation tasks fail.

Reproduction Steps

Create a new integration step using the QueueProcessingFargateService, using the same Docker and the index.py with no webserver and the docker should be using the CMD command.

Possible Solution

  1. Separate Docker file for separate fargate integration tests.
  2. Queue processing is different from application load balancer.

Additional Information/Context

No response

CDK CLI Version

NA

Framework Version

2.115

Node.js Version

NA

OS

NA

Language

TypeScript

Language Version

No response

Other information

No response
@AnuragMohapatra AnuragMohapatra added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 15, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Dec 15, 2023
@AnuragMohapatra AnuragMohapatra changed the title (aws-ecs-patterns): Integration testing of aws-ecs-patterns has a invalid docker file (aws-ecs-patterns): Integration testing of aws-ecs-patterns contains an invalid integration test Dec 15, 2023
@AnuragMohapatra AnuragMohapatra mentioned this issue Dec 15, 2023
Merged
@pahud
Copy link
Contributor

pahud commented Dec 15, 2023

Yes I see your point.

aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.queue-processing-fargate-service-public.ts

Line 18 in 7c62d68

command: ['CMD-SHELL', 'curl -f http://localhost/ || exit 1'],

The sqs-reader is not actually listening on http port so the health check would always fail.

Are you interested to submit a PR for that?

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 15, 2023
@AnuragMohapatra AnuragMohapatra mentioned this issue Dec 22, 2023
Merged
@mergify mergify bot closed this as completed in #28463 Dec 23, 2023
mergify bot pushed a commit that referenced this issue Dec 23, 2023
@AnuragMohapatra
chore(ecs-patterns): fix the integration tests of queue processing fa…
9d3f95b 
…rgate service (#28463)

1. Fixed the docker image to use Python 3.11 to stop the python3.6 out of date warning/error
2. Fixed the lambda container's entry point handler, causing the integration tests to go into an infinite loop.
3. Fixed/changed the public integration test to a health check test as the queue processing fargate service doesn't have a public-facing feature.


Closes #28383.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Jan 1, 2024
Closed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
@AnuragMohapatra @paulhcsun
chore(ecs-patterns): fix the integration tests of queue processing fa…
d4b1a29 
…rgate service (aws#28463)

1. Fixed the docker image to use Python 3.11 to stop the python3.6 out of date warning/error
2. Fixed the lambda container's entry point handler, causing the integration tests to go into an infinite loop.
3. Fixed/changed the public integration test to a health check test as the queue processing fargate service doesn't have a public-facing feature.


Closes aws#28383.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ecs-patterns): fix the integration tests of queue processing fargate service
2 participants
@pahud @AnuragMohapatra