Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(iam): The naming conventions for IAM role names have not been verified #28502

Closed
1 of 2 tasks
badmintoncryer opened this issue Dec 27, 2023 · 2 comments · Fixed by #28509
Closed
1 of 2 tasks

(iam): The naming conventions for IAM role names have not been verified #28502

badmintoncryer opened this issue Dec 27, 2023 · 2 comments · Fixed by #28509
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Dec 27, 2023 •
edited
Loading

Describe the feature

There are characters that cannot be used in IAM role names. (e.g., "/")

I propose a feature for CDK to verify that it adheres to this naming convention.

Use Case

If a name containing forbidden characters is set for the role name, no error occurs at the stage of ‘cdk synth’, but it fails during deployment. Therefore, I believe it would be preferable to trigger an error at the synth stage.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.116.1

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 27, 2023
@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Dec 27, 2023
@pahud
Copy link
Contributor

pahud commented Dec 27, 2023

Sounds good! Thank you for the PR.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 27, 2023
@frattallone frattallone mentioned this issue Dec 28, 2023
Merged
@github-actions github-actions bot mentioned this issue Jan 1, 2024
Closed
@mergify mergify bot closed this as completed in #28509 Jan 2, 2024
mergify bot pushed a commit that referenced this issue Jan 2, 2024
@frattallone
feat(iam): validate roleName (#28509)
999c01a 
> Validates roleName


Closes #28502 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
@frattallone @paulhcsun
feat(iam): validate roleName (aws#28509)
0b63325 
> Validates roleName


Closes aws#28502 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(iam): validate roleName frattallone/aws-cdk
2 participants
@pahud @badmintoncryer