Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-signer: Signer Profile construct should support Notation-OCI-SHA384-ECDSA platform #28580

Closed
1 of 2 tasks
Sohail-Haaris-bah opened this issue Jan 4, 2024 · 2 comments · Fixed by #28612 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Closed
1 of 2 tasks

aws-signer: Signer Profile construct should support Notation-OCI-SHA384-ECDSA platform #28580

Sohail-Haaris-bah opened this issue Jan 4, 2024 · 2 comments · Fixed by #28612 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Labels
@aws-cdk/aws-signer effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@Sohail-Haaris-bah
Copy link

Describe the feature

The L2 construct for creating a Signer Profile in AWS Signer doesn't support creating a singer profile with the Notation-OCI-SHA384-ECDSA signing platform. This is odd, given that the L1 construct for it does. As such, I'd like to open a PR for the construct to add this capability, assuming that it just involves adding an instantiation to the Platform class.

Use Case

AWS documentation recommends using this particular signing profile for creating an AWS Signer configuration for signing Docker images that get pushed to an ECR repository.

Proposed Solution

Adding a new enum value for the Platform class. https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-signer/lib/signing-profile.ts#L9

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.x

Environment details (OS name and version, etc.)

MacOS
@Sohail-Haaris-bah Sohail-Haaris-bah added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 4, 2024
@pahud
Copy link
Contributor

pahud commented Jan 4, 2024

Awesome! Thanks for the PR!

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 4, 2024
@lpizzinidev lpizzinidev mentioned this issue Jan 8, 2024
Merged
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Jan 8, 2024
@mergify
Merge branch 'main' into awsgh-28580
2d7af03
@mergify mergify bot closed this as completed in #28612 Jan 8, 2024
mergify bot pushed a commit that referenced this issue Jan 8, 2024
@lpizzinidev
feat(signer): Notation-OCI-SHA384-ECDSA platform (#28612)
d7aa196 
Adds support for the `Notation-OCI-SHA384-ECDSA` signing profile platform.
Also, refactors the `Platform` class to an enum-like class to allow custom platforms (and prevent blocking users if added platforms are missing on the `enum` declaration).

Closes #28580.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
This was referenced Feb 10, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-signer effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@pahud @Sohail-Haaris-bah