(prlint): instructions for exemption/clarification should not be shown if already requested #28803
Assignees
Labels
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
package/tools
Related to AWS CDK Tools or CLI
Comments
laurelmay
added
bug
pahud
added
p2
effort/medium
mergify bot
pushed a commit
that referenced
this issue
Feb 9, 2024
…een submitted (#29000) ### Issue # (if applicable) Closes #28803 ### Reason for this change If a contributor requests an exemption or clarification for a PR, they will get a second message (due to the comment event) telling them again that they can request an exemption/clarification. This may confuse contributors, especially beginners. ### Description of changes Detect if an exempt request comment already exists, next comment would mention an request has been submitted and waiting for a maintainer's review. ### Description of how you validated changes unit tests *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
TheRealAmazonKendra
pushed a commit
that referenced
this issue
Feb 9, 2024
…een submitted (#29000) ### Issue # (if applicable) Closes #28803 ### Reason for this change If a contributor requests an exemption or clarification for a PR, they will get a second message (due to the comment event) telling them again that they can request an exemption/clarification. This may confuse contributors, especially beginners. ### Description of changes Detect if an exempt request comment already exists, next comment would mention an request has been submitted and waiting for a maintainer's review. ### Description of how you validated changes unit tests *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If a contributor requests an exemption or clarification for a PR, they will get a second message (due to the comment event) telling them again that they can request an exemption/clarification. This may confuse contributors, especially beginners.
Expected Behavior
After an exemption, ideally future messages from
prlinterwould instead end with a message acknowledging that the exemption/clarification has been requested (but also still with the reasons for the failure).Current Behavior
Every message ends with:
Reproduction Steps
Possible Solution
No response
Additional Information/Context
Looking over PRs in
is:pr label:pr-linter/exemption-requested is:closed label:beginning-contributorshow several where contributors have requested exemptions or clarifications multiple times.CDK CLI Version
N/A
Framework Version
No response
Node.js Version
N/A
OS
N/A
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: