aws-lambda: logRetention deprecation messages for Provider or CustomResource (most likely)

[holomekc]

Describe the bug

After the deprecation of logRetention, we migrated the usage to logGroup. Sadly our logs are still full of deprecation warnings. After some debugging our assumption is that this is related to either the Provider or CustomResource construct. We tried to remove logRetention from Provider, but this does not help and there is no logGroup method available. So I assume somewhere under the hood you guys also still use logRetention.

Expected Behavior

AWS CDK internally also does not use logRetention anymore, or at least the warnings are not shown in this case.

Current Behavior

Logs are full of:

[WARNING] aws-cdk-lib.aws_lambda.FunctionOptions#logRetention is deprecated.
  instead create a fully customizable log group with `logs.LogGroup` and use the `logGroup` property to instruct the Lambda function to send logs to it.
Migrating from `logRetention` to `logGroup` will cause the name of the log group to change.
Users and code and referencing the name verbatim will have to adjust.

In AWS CDK code, you can access the log group name directly from the LogGroup construct:
\```ts
declare const myLogGroup: logs.LogGroup;
myLogGroup.logGroupName;
\```
  This API will be removed in the next major release.

Reproduction Steps

As said I did not check your code, but the assumption is when using Provider in combination with CustomResource creates this issue.

Possible Solution

• Migrate the internal code to logGroup as well
• Make sure that the logs are not flooded

Additional Information/Context

No response

CDK CLI Version

2.122.0

Framework Version

No response

Node.js Version

20.11.0

OS

OSX

Language

Java

Language Version

Java 17

Other information

No response

[laurelmay]

I think there is a fix in the works at #28783

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[saurabhmarwaha]

@mrgrain Any solution or workaround to this yet? I am still getting this error. Specific issue is given #28809

I didn't understand what to do based on

[WARNING] aws-cdk-lib.aws_lambda.FunctionOptions#logRetention is deprecated.
instead create a fully customizable log group with logs.LogGroup and use the logGroup property to instruct the Lambda function to send logs to it.
Migrating from logRetention to logGroup will cause the name of the log group to change.
Users and code and referencing the name verbatim will have to adjust.

In AWS CDK code, you can access the log group name directly from the LogGroup construct:

declare const myLogGroup: logs.LogGroup;
myLogGroup.logGroupName;

[mrgrain]

@saurabhmarwaha see #28783 (comment)