Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudformation-include: outputs resource id misspelled $Ouputs #28908

Closed
jbschooley opened this issue Jan 29, 2024 · 2 comments · Fixed by #28916
Closed

cloudformation-include: outputs resource id misspelled $Ouputs #28908

jbschooley opened this issue Jan 29, 2024 · 2 comments · Fixed by #28916
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package bug This issue is a bug. effort/medium Medium work item – several days of effort p1

Comments

@jbschooley
Copy link

Describe the bug

The ID of the construct containing outputs in an imported CloudFormation stack is spelled $Ouputs rather than $Outputs.

Expected Behavior

The ID should be $Outputs

Current Behavior

The ID is $Ouputs

Reproduction Steps

  • import a cfn template
  • attempt to access the outputs construct with cfnInclude.node.tryFindChild('$Outputs') (which is what you'd expect to access it with)
  • can't find child
  • cfnInclude.node.tryFindChild('$Ouputs') works

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.124.0 (build 4b6724c)

Framework Version

No response

Node.js Version

v20.11.0

OS

Windows 11 22H2

Language

TypeScript

Language Version

No response

Other information

No response
@jbschooley jbschooley added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2024
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Jan 29, 2024
@pahud
Copy link
Contributor

pahud commented Jan 29, 2024

Thank you for the report.

aws-cdk/packages/aws-cdk-lib/cloudformation-include/lib/cfn-include.ts

Line 176 in 6a7a24a

const outputScope = new Construct(this, '$Ouputs');

@pahud pahud added p1 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2024
@ayush-shah-1501 ayush-shah-1501 mentioned this issue Jan 29, 2024
Merged
@mergify mergify bot closed this as completed in #28916 Jan 30, 2024
mergify bot pushed a commit that referenced this issue Jan 30, 2024
@ayush-shah-1501
chore(cloudformation-include): outputs resource id misspelled $Ouputs (…
a441d37 
…#28916)

Fix the misspelled of outputs resource id $Ouputs.

Closes #28908 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
SankyRed pushed a commit that referenced this issue Feb 8, 2024
@ayush-shah-1501 @SankyRed
chore(cloudformation-include): outputs resource id misspelled $Ouputs (…
c148af0 
…#28916)

Fix the misspelled of outputs resource id $Ouputs.

Closes #28908 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package bug This issue is a bug. effort/medium Medium work item – several days of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cloudformation-include): outputs resource id misspelled $Ouputs ayush-shah-1501/aws-cdk
2 participants
@pahud @jbschooley