(aws-appsync): addRdsDataSource doesnt support taking a DatabaseCluster

[antoniordz96]

Describe the bug

Aurora V2 Serverless now supports the Data API but from researching online the CDK recommended way to create v2 database is using the DatabaseCluster construct.

The method addRdsDataSource part of Appsync does not allow us to pass the DatabaseCluster as a datasource.

I think we should allow either DatabaseCluster or ServerlessCluster. Right now it seems only objects that implement Iserverlesscluster are allowed.

Expected Behavior

Allow me to pass the DatabaseCluster to the addRdsDataSource method

Current Behavior

We're gonna try to use the L1 construct instead CfnDataSource as that just requires database information thats available in both constructs

Reproduction Steps

this.dbCluster = new rds.DatabaseCluster(this, 'DbCluster', {
      engine: this.databaseClusterEngine,
      backup: {
        // TODO(delta-database): Do we have a recommended back retention?
        retention: Duration.days(this.props.backupRetentionDays),
        // TODO(delta-database): What time frame do we want
        preferredWindow: this.props.backupRetentionPreferredWindow,
      },
      // https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbcluster.html#cfn-rds-dbcluster-enablecloudwatchlogsexports
      cloudwatchLogsExports: ['postgresql'],
      // TODO(delta-database): Do we have a recommended log retention?
      cloudwatchLogsRetention: RetentionDays.ONE_MONTH,
      clusterIdentifier: this.props.clusterIdentifier,
      copyTagsToSnapshot: true,
      deletionProtection: this.props.deletionProtection,
      iamAuthentication: true,
      instanceUpdateBehaviour: rds.InstanceUpdateBehaviour.ROLLING,
      monitoringInterval: Duration.seconds(60),
      parameterGroup: this.databaseClusterParameterGroup,
      port: 5432,
      // TODO(ccoe) preferredMaintenanceWindow determine value
      preferredMaintenanceWindow: this.props.preferredMaintenanceWindow,
      removalPolicy: RemovalPolicy.SNAPSHOT,
      securityGroups: this.props.securityGroups,
      serverlessV2MaxCapacity: this.props.serverlessV2MaxCapacity,
      serverlessV2MinCapacity: this.props.serverlessV2MinCapacity,
      storageEncrypted: true,
      storageEncryptionKey: this.props.encryptionKey,
      subnetGroup: this.databaseSubnetGroup,
      writer: rds.ClusterInstance.serverlessV2('writer'),
      vpc: this.props.vpc,
    });

    const auroraDataSource = appSyncApi.addRdsDataSource('AuroraDataSource', dbCluster);

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.130

Framework Version

No response

Node.js Version

v18.15.0

OS

MAC

Language

TypeScript

Language Version

No response

Other information

No response

[pahud]

Yes we should support that. I'm making it a feature request and we welcome any PRs from the community.

aws-cdk/packages/aws-cdk-lib/aws-appsync/lib/graphqlapi-base.ts

Lines 188 to 190 in d308818

	addRdsDataSource(
	id: string,
	serverlessCluster: IServerlessCluster,

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.