Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-location-alpha: support L2 Geofence Collection Construct #30710

Closed
1 of 2 tasks
mazyu36 opened this issue Jun 30, 2024 · 3 comments · Fixed by #30711 · May be fixed by mannjaro/serverless-bedrock-proxy#4
Closed
1 of 2 tasks

aws-location-alpha: support L2 Geofence Collection Construct #30710

mazyu36 opened this issue Jun 30, 2024 · 3 comments · Fixed by #30711 · May be fixed by mannjaro/serverless-bedrock-proxy#4
Labels
@aws-cdk/aws-location-alpha Related to the @aws-cdk/aws-location-alpha package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Jun 30, 2024

Describe the feature

In aws-location-alpha, geofence collection has not been supported yet.

Adding the GeofenceCollection class to the alpha module enables easier usage.

Use Case

To use geofence collection.

Proposed Solution

Add GeofenceCollection class.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.147.0

Environment details (OS name and version, etc.)

all
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 30, 2024
@github-actions github-actions bot added the @aws-cdk/aws-location-alpha Related to the @aws-cdk/aws-location-alpha package label Jun 30, 2024
@mazyu36 mazyu36 mentioned this issue Jun 30, 2024
Merged
1 task
This was referenced Jul 1, 2024
Closed
Closed
Closed
@pahud
Copy link
Contributor

pahud commented Jul 1, 2024

Thank you @mazyu36

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 1, 2024
@mazyu36 mazyu36 mentioned this issue Jul 11, 2024
Open
2 tasks
@mergify mergify bot closed this as completed in #30711 Aug 29, 2024
@mergify mergify bot closed this as completed in 04d73ac Aug 29, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
xazhao pushed a commit to xazhao/aws-cdk that referenced this issue Sep 12, 2024
@mazyu36 @xazhao
feat(location): support GeofenceCollection (aws#30711)
ffe9fa3 
### Issue # (if applicable)

Closes aws#30710.

### Reason for this change
To support L2 level geofence collection.



### Description of changes
Add `Geofence Collection` class.



### Description of how you validated changes
Add unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-location-alpha Related to the @aws-cdk/aws-location-alpha package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@pahud @mazyu36