Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iot): FirehoseStreamAction is now called FirehosePutRecordAction #18356

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

yamatatsu
Copy link
Contributor

@yamatatsu yamatatsu commented Jan 11, 2022

By #18321 (comment)

BREAKING CHANGE: the class FirehoseStreamAction has been renamed to FirehosePutRecordAction


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 11, 2022

@github-actions github-actions bot added the @aws-cdk/aws-iot Related to AWS IoT label Jan 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@yamatatsu yamatatsu changed the title chor(iot): rename firehose action chore(iot): rename firehose action Jan 11, 2022
@skinny85 skinny85 changed the title chore(iot): rename firehose action fix(iot): FirehoseStreamAction is now called FirehosePutRecordAction Jan 11, 2022
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yamatatsu!

@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c016a9f into aws:master Jan 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7e30c26
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@yamatatsu yamatatsu deleted the aws-iot-actions-rename-firehose-action branch January 12, 2022 01:23
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…on` (aws#18356)

By aws#18321 (comment)

BREAKING CHANGE: the class `FirehoseStreamAction` has been renamed to `FirehosePutRecordAction`

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iot Related to AWS IoT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants