Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(elasticloadbalancingv2-actions): update integ tests #21642

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

TheRealAmazonKendra
Copy link
Contributor

Updating these tests to use the new integ runner and updating the readme to not have someone's commentary about the test/readme not being complete.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Updating these tests to use the new integ runner and updating the readme to not have someone's commentary about the test/readme not being complete.
@gitpod-io
Copy link

gitpod-io bot commented Aug 17, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 17, 2022
@github-actions github-actions bot added the p2 label Aug 17, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 17, 2022 15:50
@Naumel
Copy link
Contributor

Naumel commented Aug 17, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

update

✅ Branch has been successfully updated

Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7a1427d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7873bde into main Aug 17, 2022
@mergify mergify bot deleted the TheRealAmazonKendra/test-updates branch August 17, 2022 20:56
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
Updating these tests to use the new integ runner and updating the readme to not have someone's commentary about the test/readme not being complete.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants