Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Custom Resource type length validation #22118

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

dontirun
Copy link
Contributor

The resource type length validation did not include the Custom:: prefix which CloudFormation counts towards the total character count

Related to #22055


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 19, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team September 19, 2022 17:19
@github-actions github-actions bot added the p2 label Sep 19, 2022
@dontirun
Copy link
Contributor Author

dontirun commented Oct 7, 2022

This is related to #22119 @corymhall

@Naumel
Copy link
Contributor

Naumel commented Oct 7, 2022

Hello, thank you for taking the time and submitting a review -- have you noticed the PR linter failing on a lack of testing?

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@dontirun
Copy link
Contributor Author

dontirun commented Oct 7, 2022

@Naumel I missed that, I thought I had added one in 🤦🏾‍♂️. Added one!

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 7, 2022 14:07

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a15f22a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c186e2d into aws:main Oct 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@dontirun dontirun deleted the fix-custom-resource-type-length-validation branch October 10, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants