Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pr-linter): use github-actions bot to write to PRs #22152

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

TheRealAmazonKendra
Copy link
Contributor

temp fix until we can get the aws-cdk-automation working correctly on this.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

temp fix until we can get the aws-cdk-automation working correctly on this.
@gitpod-io
Copy link

gitpod-io bot commented Sep 20, 2022

@github-actions github-actions bot added the p2 label Sep 20, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team September 20, 2022 19:31
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 20, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(pr-linter): use github-actions bot to write to PRs chore(pr-linter): use github-actions bot to write to PRs Sep 20, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the title chore(pr-linter): use github-actions bot to write to PRs fix(pr-linter): use github-actions bot to write to PRs Sep 20, 2022
@TheRealAmazonKendra
Copy link
Contributor Author

Calling it a fix for a sec to make sure github actions cleans this up on change.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pull Request Linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Sep 20, 2022
@github-actions github-actions bot dismissed their stale review September 20, 2022 19:38

Pull Request updated. Dissmissing previous PRLinter Review.

@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(pr-linter): use github-actions bot to write to PRs chore(pr-linter): use github-actions bot to write to PRs Sep 20, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 74c1a9b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cfaf2ba into main Sep 20, 2022
@mergify mergify bot deleted the TheRealAmazonKendra/pr-lint-fix branch September 20, 2022 20:13
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Dec 1, 2022
temp fix until we can get the aws-cdk-automation working correctly on this.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants