Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contributing guide with merit badger info #22172

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

kaizencc
Copy link
Contributor

This PR piggybacks on #21898.

@gitpod-io
Copy link

gitpod-io bot commented Sep 21, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team September 21, 2022 14:46
@github-actions github-actions bot added the p2 label Sep 21, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 21, 2022
CONTRIBUTING.md Show resolved Hide resolved

CDK Merit Badges is a program aimed at enhancing the CDK contributor experience. When you
submit new pull requests to the CDK repository, you will receive a merit badge that reflects
how many prior successful contributions you have to the repository. Right now, these badges
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expect questions regarding what will they be used for in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that is the natural follow up question, but I mean to leave this ambiguous. I don't want to commit to any ideas, and we don't know if/how we will use them in the future. I do mean to suggest that it's possible that badges could have different rewards/incentives attached in the future, just not now.

@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Sep 22, 2022
@kaizencc kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label Sep 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5c7cc4e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3511ea0 into main Sep 22, 2022
@mergify mergify bot deleted the conroy/meritbadger branch September 22, 2022 19:18
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

homakk pushed a commit to homakk/aws-cdk that referenced this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants