docs(elasticloadbalancing): update readme on internetFacing #24732
Conversation
pattasai
added
@aws-cdk/aws-elasticloadbalancing
pattasai
changed the title
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
TheRealAmazonKendra
changed the title
TheRealAmazonKendra
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
| @@ -18,7 +18,9 @@ classic load balancers. | |||
|
|
|||
| Load balancers send traffic to one or more AutoScalingGroups. Create a load | |||
| balancer, set up listeners and a health check, and supply the fleet(s) you want | |||
| to load balance to in the `targets` property. | |||
| to load balance to in the `targets` property. We also need to set `internetFacing` as `true` on | |||
There was a problem hiding this comment.
Can this be phrased without we here? this doesn't quite match the tone of the readme.
| to load balance to in the `targets` property. Additionally, you need to set `internetFacing` | ||
| as `true` on the load balancer(this is an internet facing load balancer), otherwise the | ||
| load balancer would not be accessible from the internet. |
There was a problem hiding this comment.
You're phrasing this as "you MUST do this otherwise it will not be accessible from the internet". If it had been mandatory to always put internetFacing: true, then we would have done it for you 🤓 that's the point of CDK!
It's not necessary for the load balancer to be accessible from the internet. You may create a load balancer for internal services that just want to talk to each other on a private network (and for safety reasons that is the default).
So that the very least, you should phrase this as "If you want the load balancer to be accessible from the internet, set internetFacing: true."
pattasai
force-pushed
the
documenting-elb-internetFacing
branch
from
bf7e8b0
to
0b8c7a2
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR adds the documentation in the readme about
internetFacingon classic load balancer .Closes #.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license