chore(region-info): register eu-central-2, fix firehose cidr blocks for ap-south-2, eu-south-2, me-central-1 #25572
Conversation
Signed-off-by: Sumu <sumughan@amazon.com>
|
|
github-actions
bot
added
effort/medium
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
| @@ -273,7 +273,7 @@ | |||
| "FirehoseCidrBlock": "35.158.127.160/27" | |||
| }, | |||
| "eu-central-2": { | |||
| "FirehoseCidrBlock": "16.62.183.32/27" | |||
| "FirehoseCidrBlock": "16.62.183.64/26/27" | |||
There was a problem hiding this comment.
Same for eu-south-2 by the way, although that's not your PR
There was a problem hiding this comment.
And me-central-1 and a bunch of others. I think we need to refactor how the firehose cidr block fact works.
There was a problem hiding this comment.
Yea this does look strange. I'll update these by removing the /26 from the numbers
| // 'eu-central-2', | ||
| // 'ap-south-2', |
There was a problem hiding this comment.
(Non-blocking) Side note: This change is a noop. We probably should order that list alphabetically.... 🙈
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
…ws/aws-cdk into sumughan/register-eu-central-2
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
There was a problem hiding this comment.
Revert this change, it's unrelated.
mrgrain
changed the title
| 'me-central-1': '3.28.159.64/26', | ||
| 'me-central-1': '15.185.91.0', |
There was a problem hiding this comment.
According to the link this should be 3.28.159.32
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Checks off some items from #24477
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license