Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): Rds version upgrade #26098

Merged
merged 8 commits into from
Jun 27, 2023
Merged

Conversation

@gitpod-io
Copy link

gitpod-io bot commented Jun 23, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 23, 2023 11:53
@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Jun 23, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 23, 2023
Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you effort. Things look great, except a missing 0 (see suggestion please)

@@ -315,6 +315,8 @@ export class MariaDbEngineVersion {
public static readonly VER_10_3_37 = MariaDbEngineVersion.of('10.3.37', '10.3');
/** Version "10.3.38". */
public static readonly VER_10_3_38 = MariaDbEngineVersion.of('10.3.38', '10.3');
/** Version "10.3.39". */
public static readonly VER_10_3_39 = MariaDbEngineVersion.of('10.3.39', '10.3');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1435,6 +1449,8 @@ export class OracleEngineVersion {
public static readonly VER_19_0_0_0_2022_10_R1 = OracleEngineVersion.of('19.0.0.0.ru-2022-10.rur-2022-10.r1', '19');
/** Version "19.0.0.0.ru-2023-01.rur-2023-01.r1". */
public static readonly VER_19_0_0_0_2023_01_R1 = OracleEngineVersion.of('19.0.0.0.ru-2023-01.rur-2023-01.r1', '19');
/** Version "19.0.0.0.ru-2023-04.rur-2023-04.r1". */
public static readonly VER_19_0_0_0_2023_04_R1 = OracleEngineVersion.of('19.0.0.0.ru-2023-04.rur-2023-04.r1', '19');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1697,6 +1715,8 @@ export class SqlServerEngineVersion {
public static readonly VER_12_00_6433_1_V1 = SqlServerEngineVersion.of('12.00.6433.1.v1', '12.00');
/** Version "12.00.6439.10.v1". */
public static readonly VER_12_00_6439_10_V1 = SqlServerEngineVersion.of('12.00.6439.10.v1', '12.00');
/** Version "12.00.6444.4.v1". */
public static readonly VER_12_00_6444_4_V1 = SqlServerEngineVersion.of('12.00.6444.4.v1', '12.00');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts Outdated Show resolved Hide resolved
Naumel
Naumel previously approved these changes Jun 26, 2023
@mergify mergify bot dismissed Naumel’s stale review June 27, 2023 05:33

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5dab48c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c51e8c7 into aws:main Jun 27, 2023
5 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@watany-dev watany-dev deleted the rds-version-upgrade branch June 28, 2023 14:08
lukey-aleios pushed a commit to lukey-aleios/aws-cdk that referenced this pull request Jun 30, 2023
- [Amazon RDS for Oracle now supports April 2023 Release Update for 19c](https://aws.amazon.com/about-aws/whats-new/2023/05/amazon-rds-oracle-april-2023-update-19c/)
- [Amazon RDS for Oracle now supports April 2023 Release Update for 21c](https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-rds-oracle-april-2023-ru-21c/)
- [Amazon RDS for SQL Server supports minor versions 2014 GDR, 2016 GDR, 2017 CU31 GDR, and 2019 CU20](https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-rds-sql-server-new-minor-versions/)
- [Amazon RDS for MariaDB supports minor versions 10.6.14, 10.5.21, 10.4.30](https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-rds-mariadb-new-minor-version-support/)
- [Amazon RDS for MariaDB supports minor versions 10.6.13, 10.5.20, 10.4.29, 10.3.39](https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-rds-maria-db-minor-versions/)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
lukey-aleios pushed a commit to lukey-aleios/aws-cdk that referenced this pull request Jun 30, 2023
- [Amazon RDS for Oracle now supports April 2023 Release Update for 19c](https://aws.amazon.com/about-aws/whats-new/2023/05/amazon-rds-oracle-april-2023-update-19c/)
- [Amazon RDS for Oracle now supports April 2023 Release Update for 21c](https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-rds-oracle-april-2023-ru-21c/)
- [Amazon RDS for SQL Server supports minor versions 2014 GDR, 2016 GDR, 2017 CU31 GDR, and 2019 CU20](https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-rds-sql-server-new-minor-versions/)
- [Amazon RDS for MariaDB supports minor versions 10.6.14, 10.5.21, 10.4.30](https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-rds-mariadb-new-minor-version-support/)
- [Amazon RDS for MariaDB supports minor versions 10.6.13, 10.5.20, 10.4.29, 10.3.39](https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-rds-maria-db-minor-versions/)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants