Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support bundling for single non-archive file #26106

Merged
merged 12 commits into from
Aug 23, 2023
Merged

feat(core): support bundling for single non-archive file #26106

merged 12 commits into from
Aug 23, 2023

Conversation

hoegertn
Copy link
Contributor

This PR adds a possibility to use local bundling and let the final asset be one single file that is uploaded as-is.

This can be used for several types of assets, e.g. AppSync functions.

In contrast to Lambda, these functions to not expect the asset to be a zip file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 23, 2023

@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jun 23, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 23, 2023 21:12
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@hoegertn
Copy link
Contributor Author

Exemption Request:

I did not find any place where the bundling type is documented. Is this a needed addition?

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 28, 2023
@mrgrain mrgrain added the pr-linter/exempt-readme The PR linter will not require README changes label Jul 6, 2023
mrgrain
mrgrain reviewed Jul 6, 2023
View reviewed changes
packages/aws-cdk-lib/core/test/staging.test.ts Outdated
});

// TODO test here hoegertn
Copy link
Contributor

@mrgrain mrgrain Jul 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@aws-cdk-automation aws-cdk-automation dismissed their stale review July 6, 2023 17:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mrgrain
mrgrain reviewed Jul 6, 2023
View reviewed changes
...s/@aws-cdk-testing/framework-integ/test/aws-s3-assets/test/integ.assets.file-bundling.lit.ts
Comment on lines +35 to +37
new IntegTest(app, 'IntegTest', {
testCases: [stack],
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can add an assertions that checks the file is in the expected location and format, as opposed to being in a zip-archive?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be easier to test that as a unit test though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a unit test

@hoegertn hoegertn mentioned this pull request Jul 13, 2023
Closed
2 tasks
mrgrain
mrgrain previously requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments as before

@mrgrain mrgrain removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 18, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 18, 2023
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
@mergify mergify bot dismissed mrgrain’s stale review August 1, 2023 22:20

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 1, 2023
mrgrain
mrgrain previously requested changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoegertn Can you have a look at my comments and address the requested changes?

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 2, 2023
@mergify mergify bot dismissed mrgrain’s stale review August 2, 2023 22:44

Pull request has been modified.

@mrgrain mrgrain added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 9, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 9, 2023
rix0rrr
rix0rrr previously approved these changes Aug 23, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mrgrain
mrgrain previously approved these changes Aug 23, 2023
View reviewed changes
@mrgrain
Copy link
Contributor

mrgrain commented Aug 23, 2023

Thanks @hoegertn ! Apologies this took a while.

@mergify mergify bot dismissed stale reviews from rix0rrr and mrgrain August 23, 2023 12:15

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ed4213d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0aee083 into aws:main Aug 23, 2023
9 checks passed
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@mrgrain mrgrain mrgrain left review comments

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hoegertn @mrgrain @aws-cdk-automation @rix0rrr @kaizencc