Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(batch): SSM parameters can't be used as ECS Container secrets #26373

Merged
merged 5 commits into from
Jul 18, 2023
Merged

fix(batch): SSM parameters can't be used as ECS Container secrets #26373

merged 5 commits into from
Jul 18, 2023

Conversation

comcalvi
Copy link
Contributor

ECS Containers can take both Secrets Manager Secrets and SSM parameters. Currently, only Secrets manager is supported.

Closes #26339.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 14, 2023 17:16
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Jul 14, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 14, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 30654e9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bc3d6a7 into main Jul 18, 2023
5 checks passed
@mergify mergify bot deleted the comcalvi/EcsSecret branch July 18, 2023 09:11
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@comcalvi @bmoffatt
fix(batch): SSM parameters can't be used as ECS Container secrets (aw…
091a79d 
…s#26373)

ECS Containers can take both Secrets Manager Secrets and SSM parameters. Currently, only Secrets manager is supported.

Closes aws#26339.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-batch-alpha: Parameter Store secrets not supported in new version
3 participants
@comcalvi @aws-cdk-automation @mrgrain