Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ec2): update Windows version enum list #27042

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Sep 7, 2023

I took the output of the command below and found the missing ones by diffing this file.

aws ssm get-parameters-by-path --path "/aws/service/ami-windows-latest" --region us-east-1 | jq '.Parameters | .[] | .Name' | grep Windows_Server

Closes #27019.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Sep 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 7, 2023 11:39
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 7, 2023
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
Values missing after a more recent check:

Windows_Server-2022-English-Core-EKS_Optimized-1.28
Windows_Server-2022-English-Full-EKS_Optimized-1.28
Windows_Server-2012_RTM-English-Full-Base
Windows_Server-2019-English-Full-SQL_2019_Standard
Windows_Server-2012_R2_RTM-English-Full-Base
Windows_Server-2019-English-Full-EKS_Optimized-1.28
Windows_Server-2019-English-Full-SQL_2019_Standard
Windows_Server-2019-English-Core-EKS_Optimized-1.28

I think it would be useful to keep together and order at least the EKS_Optimized by version number to improve a bit this file's readability and organization.

Anyway, the ideal solution for keeping this file more organized and also allowing users to define the latest versions without having to wait for a lib update is to refactor the enum to an enum-like class.
I don't know if this is possible given that it will probably block the deployment for the changes in the interface declaration (may be worth investigating).

@msambol
Copy link
Contributor Author

msambol commented Oct 9, 2023

@lpizzinidev I added the missing ones and organized EKS optimized and then by year.

@msambol
Copy link
Contributor Author

msambol commented Oct 10, 2023

@lpizzinidev I'm getting this?

aws-cdk-lib: error: [awslint:docs-public-apis:aws-cdk-lib.aws_ec2.WindowsVersion.WINDOWS_SERVER_2022_JAPANESE_FULL_SQL_2022_ENTERPRISE] Public API element must have a docstring 

Didn't change anything significant, not sure what that's about??

@lpizzinidev
Copy link
Contributor

@msambol
Nice job with the reorganization 👍
You should add the new parameters to the list of values ignored by the linter.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 11, 2023
Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you @msambol for your contribution and thank you @lpizzinidev for reviewing this PR.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b933796
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f1b2fae into aws:main Oct 11, 2023
10 checks passed
@msambol msambol deleted the windows-versions branch October 13, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cdk-lib/aws-ec2): (Request to update Windows Version enum list)
4 participants