Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synthetics): syn-python-selenium-2.0 runtime #27565

Merged

Conversation

frichtarik
Copy link
Contributor

@frichtarik frichtarik commented Oct 16, 2023

adding missing selenium runtime for synthetics package

Closes #27566.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 16, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 16, 2023 20:25
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@frichtarik frichtarik changed the title syn-python-selenium-2.0 fix(aws-synthetics): adding syn-python-selenium-2.0 runtime Oct 16, 2023
@frichtarik frichtarik changed the title fix(aws-synthetics): adding syn-python-selenium-2.0 runtime fix(synthetics): adding syn-python-selenium-2.0 runtime Oct 16, 2023
@kaizencc kaizencc changed the title fix(synthetics): adding syn-python-selenium-2.0 runtime feat(synthetics): syn-python-selenium-2.0 runtime Oct 16, 2023
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @frichtarik! See my 1 comment, but also this PR needs an update to an existing integ test and then that integ test needs to be run and updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're not gonna add anything to the alpha package, its deprecated. in fact i'm removing the entire package today.

This comment was marked as outdated.

Copy link
Contributor Author

@frichtarik frichtarik Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification Request
I see it now, thank you.
I've limited the PR to non-alpha package, however i'm required by linter GHA to adjust integration tests ... can you please point a finger as I don't see any in the package, and i'm a bit afraid that creating full suite is a bit out of scope of my first ever contribution :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integ tests live in @aws-cdk-testing/framework-integ/test/aws-synthetics

The information for how to run is here.

You probably need to add a line very similar to this and then run the integ tests:

const selenium13 = createCanaryByRuntimes(Runtime.SYNTHETICS_PYTHON_SELENIUM_1_3);

@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Oct 16, 2023
@kaizencc
Copy link
Contributor

@frichtarik if you can't/haven't run the integ tests, I can run them for you.

@frichtarik
Copy link
Contributor Author

@frichtarik if you can't/haven't run the integ tests, I can run them for you.

i'll be actually glad, because i tried to run them on my own but they failed every time on creating autodeleteobject lambda related to s3 with Resource handler returned message: "Uploaded file must be a non-empty zip (Service: Lambda, Status Code: 400, Request ID: 62d4ae87-45fc-4285-8686-617db14fb806)"

@kaizencc
Copy link
Contributor

hmm interesting. this seems like a problem with our integ runner somewhere. i get the same error, but not when i deploy the stack with cdk deploy. i'll keep looking into it tomorrow

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 20, 2023 21:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1d5c443
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1a89ef9 into aws:main Oct 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synthetics: add selenium runtime 2.0
3 participants