Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): Add support for P5 instances EC2 #27705

Merged
merged 8 commits into from
Nov 2, 2023
Merged

feat(ec2): Add support for P5 instances EC2 #27705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
884be3d
Add support for P5 instances
niroam Oct 26, 2023
c5f374d
Merge branch 'main' into niroam-ec2-instance-type-p5
niroam Oct 26, 2023
4d634b2
Fix comments to match
niroam Oct 29, 2023
73f153c
Merge branch 'main' into niroam-ec2-instance-type-p5
niroam Oct 29, 2023
d3b537b
Update packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts
scanlonp Nov 1, 2023
fa51b63
Merge branch 'main' into niroam-ec2-instance-type-p5
scanlonp Nov 2, 2023
5f1df97
Merge branch 'main' into niroam-ec2-instance-type-p5
mergify[bot] Nov 2, 2023
6b86647
Merge branch 'main' into niroam-ec2-instance-type-p5
mergify[bot] Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,6 +880,16 @@ export enum InstanceClass {
*/
P4D = 'p4d',

/**
* Parallel-processing optimized instances, 5th generation
*/
PARALLEL5 = 'parallel5',

/**
* Parallel-processing optimized instances, 5th generation
*/
P5 = 'p5',

/**
* Arm processor based instances, 1st generation
*/
Expand Down Expand Up @@ -1391,6 +1401,8 @@ export class InstanceType {
[InstanceClass.P4DE]: 'p4de',
[InstanceClass.PARALLEL4]: 'p4d',
[InstanceClass.P4D]: 'p4d',
[InstanceClass.PARALLEL5]: 'p5',
[InstanceClass.P5]: 'p5',
[InstanceClass.ARM1]: 'a1',
[InstanceClass.A1]: 'a1',
[InstanceClass.STANDARD6_GRAVITON]: 'm6g',
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-ec2/test/instance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ describe('instance', () => {
});
test('instance architecture is correctly discerned for x86-64 instance', () => {
// GIVEN
const sampleInstanceClasses = ['c5', 'm5ad', 'r5n', 'm6', 't3a', 'r6i', 'r6a', 'p4de']; // A sample of x86-64 instance classes
const sampleInstanceClasses = ['c5', 'm5ad', 'r5n', 'm6', 't3a', 'r6i', 'r6a', 'p4de', 'p5']; // A sample of x86-64 instance classes

for (const instanceClass of sampleInstanceClasses) {
// WHEN
Expand Down