Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamodb): add seed capacity property to support changing table billing mode #27734

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Oct 27, 2023

This PR adds seedCapacity as a property on the AutoscaledCapacityOptions interface. seedCapacity must be provided for each autoscaled resource when changing a table's billing from on-demand to provisioned or from provisioned to on-demand.

Closes #27735.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… unit tests

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation requested a review from a team October 27, 2023 19:29
@github-actions github-actions bot added the p2 label Oct 27, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 27, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 27, 2023 19:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@colifran colifran marked this pull request as ready for review October 27, 2023 20:02
@github-actions github-actions bot added the feature-request A feature should be added or improved. label Oct 27, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 27, 2023
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

mergify bot commented Nov 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 1, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2cc477f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 22168b1 into main Nov 1, 2023
15 checks passed
@mergify mergify bot deleted the colifran/seed-capacity branch November 1, 2023 21:58
Copy link
Contributor

mergify bot commented Nov 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(dynamodb): add seedCapacity property to AutoscaledCapacityOptions interface to support changing table billing
3 participants