Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigateway): move url property to RestApiBase #27742

Merged
merged 12 commits into from
Dec 5, 2023
Merged

fix(apigateway): move url property to RestApiBase #27742

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0c88ca9
fix: move url property to RestApiBase
hariprakash-j Oct 29, 2023
e5eb3d8
Merge branch 'aws:main' into fix(apigateway)/restapi-url-property-fix
hariprakash-j Oct 31, 2023
c008f5b
feat: added integ and unit tests
hariprakash-j Oct 31, 2023
f6f015c
Merge branch 'main' into fix(apigateway)/restapi-url-property-fix
hariprakash-j Oct 31, 2023
a3aaf5d
fix: lint
hariprakash-j Oct 31, 2023
16ce365
fix: json in integ test
hariprakash-j Oct 31, 2023
caf54ec
fix: openapi json for tests
hariprakash-j Oct 31, 2023
d929bbb
feat: add snapshots for new tests
hariprakash-j Oct 31, 2023
05346f8
Merge branch 'main' into fix(apigateway)/restapi-url-property-fix
vinayak-kukreja Dec 4, 2023
444b415
Merge branch 'main' into fix(apigateway)/restapi-url-property-fix
mergify[bot] Dec 5, 2023
2599828
Merge branch 'main' into fix(apigateway)/restapi-url-property-fix
vinayak-kukreja Dec 5, 2023
bad5b43
Merge branch 'main' into fix(apigateway)/restapi-url-property-fix
mergify[bot] Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/aws-cdk-lib/aws-apigateway/lib/restapi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,13 @@ export abstract class RestApiBase extends Resource implements IRestApi {
return this._domainName;
}

/**
* The deployed root URL of this REST API.
*/
public get url() {
return this.urlForPath();
}

/**
* The ID of this API Gateway RestApi.
*/
Expand Down Expand Up @@ -837,13 +844,6 @@ export class RestApi extends RestApiBase {
this.node.addValidation({ validate: () => this.validateRestApi() });
}

/**
* The deployed root URL of this REST API.
*/
public get url() {
return this.urlForPath();
}

/**
* Adds a new model.
*/
Expand Down
Loading