Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add awsmjs to core contributors #28305

Merged
merged 4 commits into from
Dec 9, 2023
Merged

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Dec 8, 2023

And remove outdated information.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 8, 2023 16:07
@github-actions github-actions bot added the p2 label Dec 8, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 8, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 8, 2023
Copy link
Contributor

mergify bot commented Dec 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 8, 2023
Copy link
Contributor

mergify bot commented Dec 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@vinayak-kukreja
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Dec 8, 2023

update

✅ Branch has been successfully updated

@vinayak-kukreja
Copy link
Contributor

Weird build error like,

Installing from NPM...
npm WARN exec The following package was not found and will be installed: npm@7.24.2
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /tmp/compat-check/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/tmp/compat-check/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2023-12-08T18_40_58_360Z-debug.log

I will retrigger with empty commit

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
Copy link
Contributor

mergify bot commented Dec 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@vinayak-kukreja
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Dec 8, 2023

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5b84cca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@vinayak-kukreja vinayak-kukreja merged commit d64a85b into main Dec 9, 2023
11 checks passed
@vinayak-kukreja vinayak-kukreja deleted the conroy/add-member branch December 9, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants