Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neptune-alpha): engineVersion v1.3 #28647

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Jan 10, 2024

This PR implements support for the v1.3 engine.

Closes #28648.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 10, 2024 14:50
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Jan 10, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added the feature-request A feature should be added or improved. label Jan 10, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review January 10, 2024 16:34
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 10, 2024 16:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 10, 2024
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I made a few comments.

Comment on lines 833 to 853

test('create v1.3 engine version cluster', () => {
// GIVEN
const stack = testStack();
const vpc = new ec2.Vpc(stack, 'VPC');

// WHEN
new DatabaseCluster(stack, 'Database', {
instances: 1,
vpc,
instanceType: InstanceType.R5_LARGE,
engineVersion: EngineVersion.V1_3_0_0,
});

// THEN
Template.fromStack(stack).hasResourceProperties('AWS::Neptune::DBCluster', {
DBSubnetGroupName: { Ref: 'DatabaseSubnets3C9252C9' },
VpcSecurityGroupIds: [{ 'Fn::GetAtt': ['DatabaseSecurityGroup5C91FDCB', 'GroupId'] }],
EngineVersion: '1.3.0.0',
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to add here.

['1.1.1.0', EngineVersion.V1_1_1_0], ['1.2.0.0', EngineVersion.V1_2_0_0],

Suggested change
test('create v1.3 engine version cluster', () => {
// GIVEN
const stack = testStack();
const vpc = new ec2.Vpc(stack, 'VPC');
// WHEN
new DatabaseCluster(stack, 'Database', {
instances: 1,
vpc,
instanceType: InstanceType.R5_LARGE,
engineVersion: EngineVersion.V1_3_0_0,
});
// THEN
Template.fromStack(stack).hasResourceProperties('AWS::Neptune::DBCluster', {
DBSubnetGroupName: { Ref: 'DatabaseSubnets3C9252C9' },
VpcSecurityGroupIds: [{ 'Fn::GetAtt': ['DatabaseSecurityGroup5C91FDCB', 'GroupId'] }],
EngineVersion: '1.3.0.0',
});
});

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 11, 2024
@go-to-k
Copy link
Contributor

go-to-k commented Jan 11, 2024

The PR title would be feat(neptune-alpha): engineVersion v1.3.

badmintoncryer and others added 2 commits January 11, 2024 23:45
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
@badmintoncryer badmintoncryer changed the title feat(neptune-alpha): support for engineVersion v1.3 feat(neptune-alpha): engineVersion v1.3 Jan 11, 2024
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Jan 11, 2024
@badmintoncryer
Copy link
Contributor Author

@go-to-k Thank you for your continuous reviews! I have completed the modifications.

Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8a71186
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository