Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amplify): addBranch fails synth with "cannot find entry file..." #28658

Merged
merged 11 commits into from
Jan 16, 2024
Merged

fix(amplify): addBranch fails synth with "cannot find entry file..." #28658

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
aece9be
fix(amplify): addBranch fails with "cannot find entry file..."
kaizencc Jan 10, 2024
9015bdd
update integ
kaizencc Jan 11, 2024
0d75b98
Merge branch 'main' into conroy/amplify
kaizencc Jan 11, 2024
c52e0a5
actual update
kaizencc Jan 11, 2024
317dc0a
scripts did not get committed smh
kaizencc Jan 11, 2024
755a839
Merge branch 'main' into conroy/amplify
kaizencc Jan 11, 2024
7cd6139
force an update of snapshots
kaizencc Jan 11, 2024
0d28671
snaps
kaizencc Jan 12, 2024
637deed
Merge branch 'main' into conroy/amplify
kaizencc Jan 16, 2024
f0c0141
snapshots
kaizencc Jan 16, 2024
f3cd2fe
Merge branch 'main' into conroy/amplify
mergify[bot] Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/@aws-cdk/aws-amplify-alpha/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ junit.xml
test/
!*.lit.ts
**/*.snapshot

# include custom-resource-handlers
!custom-resource-handlers/*
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-amplify-alpha/lib/branch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ class AmplifyAssetDeploymentProvider extends NestedStack {
this,
'amplify-asset-deployment-on-event',
{
entry: path.join(__dirname, '..', '..', 'custom-resource-handlers', 'dist', 'aws-amplify-alpha', 'asset-deployment-handler', 'index.js'),
entry: path.join(__dirname, '..', 'custom-resource-handlers', 'dist', 'aws-amplify-alpha', 'asset-deployment-handler', 'index.js'),
handler: 'onEvent',
initialPolicy: [
new iam.PolicyStatement({
Expand Down
5 changes: 4 additions & 1 deletion packages/@aws-cdk/aws-amplify-alpha/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@
"cdk-build": {
"env": {
"AWSLINT_BASE_CONSTRUCT": true
}
},
"pre": [
"./scripts/airlift-custom-resource-handlers.sh"
]
},
"keywords": [
"aws",
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/custom-resource-handlers/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ and included as part of the `aws-cdk-lib` package.

### Experimental:

- None currently
- aws-amplify-alpha/asset-deployment-handler

These handlers are excluded from `aws-cdk-lib/custom-resource-handlers` and are individually
copied into their respective `-alpha` packages at build time. When an `-alpha` package is
Expand Down
Loading