docs: update integration test documentation #28781
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
HBobertz
changed the title
HBobertz
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
| yarn install # Install dependencies | ||
| npx lerna run build --scope=aws-cdk # Build the CDK cli | ||
| yarn build # Build the @aws-cdk-testing/cli-integ package | ||
| ../../../scripts/align-version.sh # Align the versions of CDK packages |
There was a problem hiding this comment.
what is this align-versions.sh script lol. I have never run that before.
There was a problem hiding this comment.
it turns all the 0.0.0s in the package.jsons into whatever the version of the cli is so the thing doesn't panic. Some tests fail unti you do this for some reason. Unsure why
There was a problem hiding this comment.
Oh shit. I wish I had known this a while ago. I've been manually working around this.
There was a problem hiding this comment.
I have never used this lol
kaizencc
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
| npx lerna run build --scope=aws-cdk # Build the CDK cli | ||
| yarn build # Build the @aws-cdk-testing/cli-integ package |
There was a problem hiding this comment.
I'd replace this with this:
| npx lerna run build --scope=aws-cdk # Build the CDK cli | |
| yarn build # Build the @aws-cdk-testing/cli-integ package | |
| cd packages/@aws-cdk-testing/cli-integ/ | |
| ../../../scripts/buildup |
That's definitely re-building everything you need for integ tests and will ignore any caches.
Also I think you've missed change the directory
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Realized there were 2 integration test docs and the one under @aws-cdk-testing had more pragmatic steps on how to run the integration tests. Updated the docs of the other integ file to link to the readme in @aws-cdk-testing and then added a section on setup for the steps on how to build the package
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license