Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudwatch): Math:UnknownIdentifier warning for INSIGHT_RULE_METRIC #28870

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

aws-sde
Copy link
Contributor

@aws-sde aws-sde commented Jan 25, 2024

The CloudWatch MathExpression class warns about identifiers missing from usingMetrics when INSIGHT_RULE_METRIC is used in the expression. It incorrectly parses the arguments to INSIGHT_RULE_METRIC as identifiers. When using INSIGHT_RULE_METRIC, I don't believe there is anything that needs to be added to usingMetrics.

This implementation follows a similar fix done for some other expressions here: #24313


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The CloudWatch MathExpression class warns about identifiers missing
from usingMetrics when INSIGHT_RULE_METRIC is used in the expression.
It incorrectly parses the arguments to INSIGHT_RULE_METRIC as
identifiers. When using INSIGHT_RULE_METRIC, I don't believe there is
anything that needs to be added to usingMetrics.
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 25, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 25, 2024 23:34
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-sde
Copy link
Contributor Author

aws-sde commented Jan 25, 2024

Exemption Request

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jan 25, 2024
@kaizencc kaizencc added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Feb 6, 2024
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 6, 2024 16:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 6, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d566a58
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7eedb54 into aws:main Feb 6, 2024
14 checks passed
TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
…IC (#28870)

The CloudWatch `MathExpression` class warns about identifiers missing from `usingMetrics` when `INSIGHT_RULE_METRIC` is used in the expression. It incorrectly parses the arguments to `INSIGHT_RULE_METRIC` as identifiers. When using `INSIGHT_RULE_METRIC`, I don't believe there is anything that needs to be added to `usingMetrics`.

This implementation follows a similar fix done for some other expressions here: #24313

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-sde aws-sde deleted the insight_rule_metric branch March 11, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants