fix(s3-notifications): unable to delete the existing S3 event notifications

[sarangarav]

Issue # (if applicable)

Reason for this change

Fix to address the issues deleting the existing S3 event notifications and adding new event notifications on top of existing notifications.

Description of changes

We fixed the hashing logic used to identify old vs external S3 event notifications

Description of how you validated changes

Manually tested the changes

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[sarangarav]

Exemption Request

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[sarangarav]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ Breaking changes in stable modules [s3-notifications] is disallowed.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

The breaking changes should be permitted to address the issues with deleting the existing S3 event notifications and adding new event notifications on top of existing notifications

[paulhcsun]

Hi @sarangarav, we don't allow any breaking changes in stable modules, however, you can still add this fix behind a feature flag: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#feature-flags.

I'm not sure exactly how it would work for changes to the index.py file but let me check with the team and get back to you. Also have you run the integ tests for s3-notifications? And if so could you also push the test snapshots if any were changed.

[paulhcsun]

this line can be removed

[paulhcsun]

Hey @sarangarav,

So the index.py file won't have any knowledge on whether or not a feature flag is enabled so what you can do is add a new property here, something like:

this.resource = new cdk.CfnResource(this, 'Resource', {
        type: 'Custom::S3BucketNotifications',
        properties: {
          ServiceToken: handler.functionArn,
          BucketName: this.bucket.bucketName,
          NotificationConfiguration: cdk.Lazy.any({ produce: () => this.renderNotificationConfiguration() }),
          Managed: managed,
		  IsFeatureFlagYouCreatedEnabled: true,
        },
      });

and then access that within the handlers() method in index.py through the props = event["ResourceProperties"] variable which will allow you to use the new logic if that property is set to true.

[aws-cdk-automation]

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[PhilippPHoffmann]

We're experiencing this exact issue and would appreciate a fix. Please don't abandon this PR.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 43e6543
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[paulhcsun]

hey @sarangarav, are you still planning to work on this?

[paulhcsun]

Going to close this for now. Feel free to open a new PR if you would like to continue to work on this fix with the suggested changes.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Breaking changes in stable modules [s3-notifications] is disallowed.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Breaking changes in stable modules [s3-notifications] is disallowed.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.