Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscaling): add support for InstanceRefresh suspended process #29113

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

mulmar-aws
Copy link
Contributor

Also add InstanceRefresh as a default suspended process for RollingUpdate.

I have also submitted a request to update https://repost.aws/knowledge-center/auto-scaling-group-rolling-updates to conform with this change.

Reason for this change

Instance Refresh is a feature of ASG. It performs a similar function to Rolling Update. If an Instance Refresh is running at the same time as a Rolling Update, the Rolling Update will fail. It is safer to suspend the process.

Description of changes

See above.

Description of how you validated changes

Unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 14, 2024 22:30
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Feb 14, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mulmar-aws mulmar-aws changed the title fix(autoscaling): Add support for InstanceRefresh suspended process fix(autoscaling): add support for InstanceRefresh suspended process Feb 14, 2024
@xazhao
Copy link
Contributor

xazhao commented Feb 15, 2024

Hello @mulmar-aws there are other tests failing which is because of missing InstanceRefresh. Could you please add it to the failing test? Also is integration test needed for this PR?

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 16, 2024 00:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mulmar-aws
Copy link
Contributor Author

mulmar-aws commented Feb 16, 2024

I think I have the integration test set up properly but I see some automated checks are failing. Let me know if I've made a mistake here!

> yarn integ --update-on-failed aws-autoscaling/test/integ.asg-update-policy.js
yarn run v1.22.21
$ integ-runner --language javascript --update-on-failed aws-autoscaling/test/integ.asg-update-policy.js

Verifying integration test snapshots...

  UNCHANGED  aws-autoscaling/test/integ.asg-update-policy 0.538s

Snapshot Results:

Tests:    1 passed, 1 total

Running integration tests for failed tests...

Running in parallel across regions: us-east-1, us-east-2, us-west-2

Test Results:

Tests:    0 passed, 0 total
✨  Done in 1.25s.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 16, 2024
@mulmar-aws
Copy link
Contributor Author

Hello, just following up to see if more changes are required?

@xazhao
Copy link
Contributor

xazhao commented Feb 29, 2024

The change looks good to me. Just one question: should the title be feat instead of fix?

@mulmar-aws mulmar-aws changed the title fix(autoscaling): add support for InstanceRefresh suspended process feat(autoscaling): add support for InstanceRefresh suspended process Mar 7, 2024
@mulmar-aws
Copy link
Contributor Author

Good point. Changed.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 7, 2024
@mulmar-aws
Copy link
Contributor Author

Exemption Request : I don't think there is anything to change in a README file here - suspended processes are not called out in detail in the AutoScaling README.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 7, 2024
@xazhao xazhao added the pr-linter/exempt-readme The PR linter will not require README changes label Mar 7, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 7, 2024 17:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

xazhao
xazhao previously approved these changes Mar 7, 2024
Copy link
Contributor

@xazhao xazhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 7, 2024
@mergify mergify bot dismissed xazhao’s stale review March 7, 2024 17:38

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 7, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fd14634
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f5e7717 into aws:main Mar 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants