Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct .NET namespace naming #29211

Closed
wants to merge 5 commits into from

Conversation

vlesierse
Copy link
Contributor

@vlesierse vlesierse commented Feb 22, 2024

Issue # (if applicable)

Closes #.

Reason for this change

Currently the naming of the API Gateway V2 NuGet packages are very different from what is expected as you can see blow in the global using example.

global using Amazon.CDK.AWS.APIGateway;
global using Amazon.CDK.AWS.Apigatewayv2;
global using Amazon.CDK.AwsApigatewayv2Authorizers;
global using Amazon.CDK.AwsApigatewayv2Integrations;

Description of changes

Adding and correcting .jsiirc.json with the right package names. The new global using will be reflected like this.

global using Amazon.CDK.AWS.APIGateway;
global using Amazon.CDK.AWS.APIGatewayV2;
global using Amazon.CDK.AWS.APIGatewayV2.Authorizers;
global using Amazon.CDK.AWS.APIGatewayV2.Integrations;

Description of how you validated changes

Package CDK and see the right NuGet package names.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 22, 2024 04:45
@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Feb 22, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vlesierse vlesierse changed the title fix(apigatewayv2): Correct NuGet package naming fix(apigatewayv2): correct NuGet package naming Feb 22, 2024
@vlesierse
Copy link
Contributor Author

vlesierse commented Feb 22, 2024

Exemption Request

This PR doesn't contain any functional code changes and only covers package naming.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 22, 2024
@mrgrain
Copy link
Contributor

mrgrain commented Feb 22, 2024

@kaizencc @xazhao Is this something that's missing in the stabilization docs?

@vlesierse
Copy link
Contributor Author

vlesierse commented Feb 22, 2024

There are many more packages which aren't correct.

Amazon.CDK.AwsArczonealshift
Amazon.CDK.AwsB2Bi
Amazon.CDK.AwsBackupgateway
Amazon.CDK.AwsCleanrooms
Amazon.CDK.AwsDatazone
Amazon.CDK.AwsEntityresolution
Amazon.CDK.AwsHealthimaging
Amazon.CDK.AwsMediapackagev2
Amazon.CDK.AwsNeptunegraph
Amazon.CDK.AwsOsis
Amazon.CDK.AwsPcaconnectorad
Amazon.CDK.AwsProton
Amazon.CDK.AwsS3Express
Amazon.CDK.AwsShield
Amazon.CDK.AwsVerifiedpermissions
Amazon.CDK.AwsWorkspacesthinclient
Amazon.CDK.AwsWorkspaceweb

I can expand the PR to include those as well?

@vlesierse
Copy link
Contributor Author

@mrgrain I have pushed the fix for the other packages are well. Apparently in the _jsiirc.json files the dotnet sections are set to package instead of namespace

@vlesierse vlesierse changed the title fix(apigatewayv2): correct NuGet package naming fix(apigatewayv2): correct .NET namespace naming Feb 28, 2024
@vlesierse vlesierse changed the title fix(apigatewayv2): correct .NET namespace naming fix: correct .NET namespace naming Feb 28, 2024
@aws-cdk-automation aws-cdk-automation removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 4, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0cce184
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Apr 2, 2024
@paulhcsun paulhcsun reopened this Apr 8, 2024
@paulhcsun paulhcsun added pr-linter/do-not-close The PR linter will not close this PR while this label is present and removed closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. labels Apr 8, 2024
@TheRealAmazonKendra TheRealAmazonKendra removed the pr-linter/do-not-close The PR linter will not close this PR while this label is present label Apr 17, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Apr 18, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants