Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events-targets): support for RedshiftDataParameters #29462

Merged
merged 46 commits into from
Aug 30, 2024
Merged

feat(events-targets): support for RedshiftDataParameters #29462

merged 46 commits into from
Aug 30, 2024

Conversation

Rizxcviii
Copy link
Contributor

@Rizxcviii Rizxcviii commented Mar 12, 2024 •
edited
Loading

Issue # (if applicable)

Closes #15712.
Closes #31017.

Reason for this change

RedshiftDataParameters allow for a redshift query to be scheduled. This feature adds that in

Description of changes

Added in the event target and the parameter into aws-events

Description of how you validated changes

Added unit tests + integration test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 12, 2024 15:09
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Mar 12, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Rizxcviii Rizxcviii changed the title feat(aws-events): Scheduling Redshift Queries feat(events): scheduling Redshift Queries Mar 12, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 12, 2024 15:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@Rizxcviii Rizxcviii changed the title feat(events): scheduling Redshift Queries feat(events-targets): scheduling Redshift Queries Mar 13, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 14, 2024
@Rizxcviii Rizxcviii changed the title feat(events-targets): scheduling Redshift Queries feat(events-targets): support for RedshiftDataParameters without the need for an L1 escape hatch Mar 14, 2024
@Rizxcviii Rizxcviii changed the title feat(events-targets): support for RedshiftDataParameters without the need for an L1 escape hatch feat(events-targets): support for RedshiftDataParameters Mar 14, 2024
@Rizxcviii
Copy link
Contributor Author

Clarification request: One workflow is failing, and I am not sure what the reason is?

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Mar 14, 2024
paulhcsun
paulhcsun previously requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Rizxcviii, apologies for leaving this review without a follow-up, thank you for making the contribution! I'll be taking over the review for this PR and I've left some comments.

packages/aws-cdk-lib/aws-events-targets/lib/redshift-query.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-events-targets/lib/redshift-query.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-events-targets/lib/redshift-query.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-events-targets/lib/redshift-query.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-events-targets/lib/redshift-query.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-events-targets/lib/redshift-query.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-events-targets/lib/redshift-query.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-events-targets/lib/redshift-query.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-events-targets/lib/redshift-query.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed paulhcsun’s stale review August 28, 2024 09:36

Pull request has been modified.

@paulhcsun paulhcsun removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Aug 28, 2024
paulhcsun
paulhcsun approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Rizxcviii!

And thanks for helping the discussion @manmartgarc!

@paulhcsun
Copy link
Contributor

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 29, 2024

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Rizxcviii
Copy link
Contributor Author

@paulhcsun, not too sure, but it seems that it's not an issue with my PR right?

@Rizxcviii
Copy link
Contributor Author

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2f310e0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 84c6442 into aws:main Aug 30, 2024
9 checks passed
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
@Rizxcviii Rizxcviii deleted the add-scheduling-a-redshift-query-to-event-targets-for-amazon-eventbridge branch August 30, 2024 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manmartgarc manmartgarc manmartgarc left review comments

@paulhcsun paulhcsun paulhcsun approved these changes

@jfuss jfuss Awaiting requested review from jfuss

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

Assignees

@jfuss jfuss

@paulhcsun paulhcsun

Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
7 participants
@Rizxcviii @TheRealAmazonKendra @manmartgarc @noel-llevares @paulhcsun @aws-cdk-automation @jfuss