Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route53): allow specifying an STS region when creating a cross-account zone delegation #29466

Merged
merged 12 commits into from
Mar 28, 2024
Merged

feat(route53): allow specifying an STS region when creating a cross-account zone delegation #29466

merged 12 commits into from
Mar 28, 2024

Conversation

naiello
Copy link
Contributor

@naiello naiello commented Mar 13, 2024

Issue # (if applicable)

n/a

Reason for this change

In certain circumstances, the default STS region resolution logic will not properly select a region due to the hardcoded mapping between region prefixes and STS regions.

Description of changes

This change allows callers to specify a region in which STS will be called.

Description of how you validated changes

Unit tests were added to aws-cdk-lib. Integ tests were updated and pass on my personal accounts, but I'm not sure how to check if they'll pass in CI.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2024 04:58
@naiello naiello changed the title Route53 cross account sts region Allow specifying a region to call STS in when delegating a cross-account Route53 zone Mar 13, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@naiello naiello changed the title Allow specifying a region to call STS in when delegating a cross-account Route53 zone feat(route53): allow specifying an STS region when creating a cross-account zone delegation Mar 13, 2024
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! Left a few comments but nothing major.

Changes look good, could you add README changes and integ tests so the linter is happy? You can use yarn integ --update-on-failed to update the snapshots of existing tests

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 19, 2024 05:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@naiello
Copy link
Contributor Author

naiello commented Mar 19, 2024

Please double-check the integ test changes as this is my first contribution to aws-cdk. The tests are passing on my personal account(s), but I'm not sure how to verify they'll pass properly in the CICD.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 19, 2024
@naiello
Copy link
Contributor Author

naiello commented Mar 22, 2024

Snapshot Results:

Tests:    1 failed, 1 total
Failed: /home/nick/projects/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.cross-account-zone-delegation.js

Running integration tests for failed tests...

Running in parallel across profiles cross-region and regions: us-east-1, us-east-2, us-west-2
Running test /home/nick/projects/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.cross-account-zone-delegation.js in cross-region/us-east-1
  SUCCESS    aws-route53/test/integ.cross-account-zone-delegation-Route53CrossAccountInteg/DefaultTest 535.347s
       NO ASSERTIONS

Test Results:

Tests:    1 passed, 1 total
Done in 536.06s.

Copy link
Contributor

@msambol msambol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍🏼

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 23, 2024
aaythapa
aaythapa previously approved these changes Mar 28, 2024
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

mergify bot commented Mar 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 28, 2024
Copy link
Contributor

mergify bot commented Mar 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aaythapa
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Mar 28, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@mergify mergify bot dismissed aaythapa’s stale review March 28, 2024 23:01

Pull request has been modified.

Copy link
Contributor

mergify bot commented Mar 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a20148d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit fe4bc1d into aws:main Mar 28, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Mar 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants