Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(opensearchservice): deprecate OpenSearch 2.10 #29469

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Mar 13, 2024

Issue # (if applicable)

None

Reason for this change

Just a single diff between the SDK and the CDK this time, OpenSearch v2.10 was removed, unsure why

Description of changes

Marked OPENSEARCH_2_10 as @deprecated

Description of how you validated changes

It is neither listed in the docs, nor in the SDK/CLI output of opensearch:ListVersions:

$ aws opensearch list-versions | jq '.Versions[] | select(.=="OpenSearch_2.10")'

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Mar 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2024 12:43
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 13, 2024
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 16, 2024
GavinZZ
GavinZZ previously approved these changes Mar 18, 2024
Copy link
Contributor

mergify bot commented Mar 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 18, 2024
Copy link
Contributor

mergify bot commented Mar 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review March 20, 2024 16:56

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0a0accd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@GavinZZ GavinZZ merged commit 3f6f88b into aws:main Mar 20, 2024
10 checks passed
@nmussy nmussy deleted the chore-opensearch-version branch March 20, 2024 17:42
ahammond pushed a commit to ahammond/aws-cdk that referenced this pull request Mar 26, 2024
### Issue # (if applicable)

None

### Reason for this change

Just a single diff between the SDK and the CDK this time, OpenSearch
v2.10 was removed, unsure why

### Description of changes

Marked `OPENSEARCH_2_10` as `@deprecated`

### Description of how you validated changes

It is neither listed in the
[docs](https://docs.aws.amazon.com/opensearch-service/latest/developerguide/supported-operations.html),
nor in the SDK/CLI output of `opensearch:ListVersions`:
```sh
$ aws opensearch list-versions | jq '.Versions[] | select(.=="OpenSearch_2.10")'
```

### Checklist
- [x] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*

Co-authored-by: GZ <yuanhaoz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants