Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add assertions to integ tests using AwsCustomResource #29950

Merged
merged 21 commits into from
Apr 25, 2024

Conversation

SankyRed
Copy link
Contributor

Closes #29937

Reason for this change

Adding assertions for AwsCustomResource will improve our test coverage.

Description of changes

Added assertions for AwsCustomResource to integ tests that were impacted by this PR.

Description of how you validated changes

Assertions were validated by running the integ tests and verifying that it succeeded.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Apr 24, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 24, 2024 16:00
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 24, 2024
colifran and others added 3 commits April 24, 2024 15:42
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
testCases: [stack],
diffAssets: true,
});

app.synth();
// Assertion to check if TestWG workgroup is present in the list of workgroups
integTest.assertions.awsApiCall('Athena', 'listWorkGroups')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

colifran and others added 13 commits April 24, 2024 17:59
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>

new integ.IntegTest(app, 'AwsCustomResourceTest', {
testCases: [
new AwsCdkSdkJsStack(app, 'aws-cdk-sdk-js'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this since we are completely migrating off SDK v2.

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@colifran colifran added the pr/do-not-merge This PR should not be merged at this time. label Apr 25, 2024
@colifran colifran marked this pull request as ready for review April 25, 2024 04:19
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5a41d85
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 25, 2024
@colifran colifran removed the pr/do-not-merge This PR should not be merged at this time. label Apr 25, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 25, 2024
Copy link
Contributor

mergify bot commented Apr 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 536d8ff into main Apr 25, 2024
25 of 26 checks passed
@mergify mergify bot deleted the SankyRed/aws-cr-assertions branch April 25, 2024 15:09
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertions for AwsCustomResource integ tests (1/2)
3 participants