Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redshift): multi AZ cluster #29976

Merged
merged 19 commits into from
May 15, 2024
Merged

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Apr 26, 2024

Issue # (if applicable)

Closes #.

Reason for this change

AWS CDK cannot configure Redshift multi-AZ cluster.

Description of changes

Add multiAz to clusterProps.

Description of how you validated changes

I've added both unit and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 26, 2024 13:41
@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Apr 26, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review April 26, 2024 14:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer marked this pull request as ready for review April 28, 2024 15:28
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 28, 2024
@badmintoncryer badmintoncryer marked this pull request as draft April 29, 2024 01:58
@badmintoncryer badmintoncryer changed the title feat(redshift-alpha): multi AZ cluster feat(redshift): multi AZ cluster Apr 29, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 29, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review April 29, 2024 03:57
@badmintoncryer badmintoncryer marked this pull request as draft April 29, 2024 12:06
@badmintoncryer badmintoncryer marked this pull request as ready for review April 29, 2024 12:08
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 29, 2024
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I made just some minor comments.

packages/@aws-cdk/aws-redshift-alpha/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-redshift-alpha/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-redshift-alpha/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-redshift-alpha/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-redshift-alpha/lib/cluster.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@shikha372 shikha372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! ..Thank you for your contribution @badmintoncryer

Copy link
Contributor

mergify bot commented May 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 14, 2024
Copy link
Contributor

mergify bot commented May 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Contributor Author

badmintoncryer commented May 14, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented May 14, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9715570
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented May 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a53517c into aws:main May 15, 2024
9 checks passed
@badmintoncryer badmintoncryer deleted the multiAzRedshiftCluster branch May 15, 2024 00:13
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants