feat(elasticloadbalancingv2): alb dualstack without public ipv4 #30248

mazyu36 · 2024-05-17T01:26:13Z

Issue # (if applicable)

Closes #30256.

Reason for this change

ALB supported a new dual-stack ALB without public IPv4.

https://aws.amazon.com/jp/about-aws/whats-new/2024/05/application-load-balancer-ipv6-internet-clients/

Description of changes

Add IpAddressType.DUAL_STACK_WITHOUT_PUBLIC_IPV4

Description of how you validated changes

Add unit tests & integ tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

watany-dev · 2024-05-17T13:57:19Z

To cdkteam, why not keep the IpAddressType.DUAL_STACK_WITHOUT_PUBLIC_IPV4 identifier but add the IpAddressType.IPV6 alias? This is essentially easy to understand.

pahud · 2024-05-17T17:44:07Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts

@@ -186,6 +186,11 @@ export class ApplicationLoadBalancer extends BaseLoadBalancer implements IApplic
    });

    this.ipAddressType = props.ipAddressType ?? IpAddressType.IPV4;
+
+    if (props.ipAddressType === IpAddressType.DUAL_STACK_WITHOUT_PUBLIC_IPV4 && !props.internetFacing) {
+      throw new Error('dual-stack without public IPv4 address can only be used with internet-facing scheme.');


do you have the link of the document about this restriction?

@pahud
Thank you for your comment.
That restriction is not mentioned in the documentation, but it is stated on the management console.

If the internal scheme is selected, the "Dual-stack without public IPv4" option disappears and cannot be configured.

pahud

DUAL_STACK_WITHOUT_PUBLIC_IPV4 supports ALB only, should we have a check that if the elbv2 with that ipAddressType is not ALB we should throw the error?

Should we add this in base-load-balancer.ts?

    // DUAL_STACK_WITHOUT_PUBLIC_IPV4 only available for ALB
    if (additionalProps.ipAddressType === IpAddressType.DUAL_STACK_WITHOUT_PUBLIC_IPV4 &&
      additionalProps.type !== cxschema.LoadBalancerType.APPLICATION) {
      throw new Error(`'ipAddressType' DUAL_STACK_WITHOUT_PUBLIC_IPV4 can only be used with ALB, got ${additionalProps.type}`);
    }

pahud · 2024-05-17T17:52:42Z

To cdkteam, why not keep the IpAddressType.DUAL_STACK_WITHOUT_PUBLIC_IPV4 identifier but add the IpAddressType.IPV6 alias? This is essentially easy to understand.

At this moment, CFN does not have ipv6 in its IpAddressType. I would avoid using that because it could mean something else when CFN adds that in the future.

mazyu36 · 2024-05-17T18:22:10Z

DUAL_STACK_WITHOUT_PUBLIC_IPV4 supports ALB only, should we have a check that if the elbv2 with that ipAddressType is not ALB we should throw the error?

Should we add this in base-load-balancer.ts?
    // DUAL_STACK_WITHOUT_PUBLIC_IPV4 only available for ALB
    if (additionalProps.ipAddressType === IpAddressType.DUAL_STACK_WITHOUT_PUBLIC_IPV4 &&
      additionalProps.type !== cxschema.LoadBalancerType.APPLICATION) {
      throw new Error(`'ipAddressType' DUAL_STACK_WITHOUT_PUBLIC_IPV4 can only be used with ALB, got ${additionalProps.type}`);
    }

@pahud
Thank you. I also thought it would be better to have validation.
I have added the validation and a unit test.

urda · 2024-05-20T17:29:29Z

Featured in the weekly roundup, adding this quickly will help teams drive lower costs.

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/shared/base-load-balancer.ts

packages/aws-cdk-lib/aws-elasticloadbalancingv2/test/nlb/load-balancer.test.ts

...mework-integ/test/aws-elasticloadbalancingv2/test/integ.alb.dualstack-without-public-ipv4.ts

…balancingv2/test/integ.alb.dualstack-without-public-ipv4.ts Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>

mazyu36 · 2024-06-21T19:04:37Z

@comcalvi
Thank you for the review!
I've updated.

aws-cdk-automation · 2024-08-10T00:09:54Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

mergify · 2024-09-11T18:36:36Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-09-11T19:09:42Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mazyu36 · 2024-09-11T22:20:28Z

@Mergifyio update

mergify · 2024-09-11T22:20:34Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

mazyu36 · 2024-09-11T22:37:15Z

@Mergifyio refresh

mergify · 2024-09-11T22:37:31Z

refresh

✅ Pull request refreshed

mazyu36 · 2024-09-11T22:42:46Z

@Mergifyio requeue

mergify · 2024-09-11T22:42:53Z

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

sender-permission>=write

mazyu36 · 2024-09-13T04:26:48Z

@Mergifyio update

mergify · 2024-09-13T04:27:02Z

update

✅ Branch has been successfully updated

mazyu36 · 2024-09-13T05:36:28Z

@Mergifyio refresh

mergify · 2024-09-13T05:36:36Z

refresh

✅ Pull request refreshed

mergify · 2024-09-13T05:37:17Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-09-13T06:08:27Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 7da04b1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-09-13T06:08:53Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-09-13T06:09:09Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team May 17, 2024 01:26

github-actions bot added p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels May 17, 2024

feat: alb dualstack without public ipv4

790c3f1

mazyu36 force-pushed the alb-ipv6 branch from f1706e2 to 8c0bbcb Compare May 17, 2024 03:03

mazyu36 had a problem deploying to test-pipeline May 17, 2024 03:04 — with GitHub Actions Failure

mazyu36 force-pushed the alb-ipv6 branch from 8c0bbcb to 790c3f1 Compare May 17, 2024 03:07

mazyu36 added 4 commits May 17, 2024 12:10

chore: existing unit tests format reverted

61c5c51

fix: README and integ tests update

c4d7a8c

update context

05001c0

chore: format

a131c16

mazyu36 marked this pull request as ready for review May 17, 2024 04:11

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 17, 2024

go-to-k mentioned this pull request May 17, 2024

elbv2: IPv6 only support #30256

Closed

2 tasks

pahud reviewed May 17, 2024

View reviewed changes

fix: add validation and unit test

381df83

chore: import fix

97a3b48

github-actions bot mentioned this pull request May 20, 2024

Weekly PR metrics report #30274

Closed

github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. labels May 21, 2024

github-actions bot mentioned this pull request Jun 1, 2024

Monthly PR metrics report #30414

Closed

mazyu36 force-pushed the alb-ipv6 branch from a9ff8be to 97a3b48 Compare June 15, 2024 13:06

comcalvi previously requested changes Jun 21, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 21, 2024

Update packages/@aws-cdk-testing/framework-integ/test/aws-elasticload…

0cfedbc

…balancingv2/test/integ.alb.dualstack-without-public-ipv4.ts Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>

mazyu36 requested a review from comcalvi June 21, 2024 19:04

Merge branch 'main' into alb-ipv6

3da9389

mazyu36 added 2 commits August 10, 2024 13:48

Merge branch 'main' into alb-ipv6

70979a9

Merge branch 'main' into alb-ipv6

768c83b

comcalvi approved these changes Sep 11, 2024

View reviewed changes

Merge branch 'main' into alb-ipv6

7e3180b

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 11, 2024

Merge branch 'main' into alb-ipv6

85cb5e5

Merge branch 'main' into alb-ipv6

7da04b1

mergify bot merged commit 4068af3 into aws:main Sep 13, 2024
9 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2024

mazyu36 deleted the alb-ipv6 branch September 13, 2024 06:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(elasticloadbalancingv2): alb dualstack without public ipv4 #30248

feat(elasticloadbalancingv2): alb dualstack without public ipv4 #30248

mazyu36 commented May 17, 2024 •

edited

Loading

watany-dev commented May 17, 2024

pahud May 17, 2024

mazyu36 May 17, 2024

pahud May 17, 2024

pahud left a comment •

edited

Loading

pahud commented May 17, 2024

mazyu36 commented May 17, 2024

urda commented May 20, 2024

mazyu36 commented Jun 21, 2024

aws-cdk-automation commented Aug 10, 2024

mergify bot commented Sep 11, 2024

mergify bot commented Sep 11, 2024

mazyu36 commented Sep 11, 2024

mergify bot commented Sep 11, 2024

mazyu36 commented Sep 11, 2024

mergify bot commented Sep 11, 2024

mazyu36 commented Sep 11, 2024

mergify bot commented Sep 11, 2024

mazyu36 commented Sep 13, 2024

mergify bot commented Sep 13, 2024

mazyu36 commented Sep 13, 2024

mergify bot commented Sep 13, 2024

mergify bot commented Sep 13, 2024

aws-cdk-automation commented Sep 13, 2024

mergify bot commented Sep 13, 2024

github-actions bot commented Sep 13, 2024

feat(elasticloadbalancingv2): alb dualstack without public ipv4 #30248

feat(elasticloadbalancingv2): alb dualstack without public ipv4 #30248

Conversation

mazyu36 commented May 17, 2024 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

watany-dev commented May 17, 2024

pahud May 17, 2024

Choose a reason for hiding this comment

mazyu36 May 17, 2024

Choose a reason for hiding this comment

pahud May 17, 2024

Choose a reason for hiding this comment

pahud left a comment • edited Loading

Choose a reason for hiding this comment

pahud commented May 17, 2024

mazyu36 commented May 17, 2024

urda commented May 20, 2024

mazyu36 commented Jun 21, 2024

aws-cdk-automation commented Aug 10, 2024

mergify bot commented Sep 11, 2024

mergify bot commented Sep 11, 2024

mazyu36 commented Sep 11, 2024

mergify bot commented Sep 11, 2024

❌ Mergify doesn't have permission to update

mazyu36 commented Sep 11, 2024

mergify bot commented Sep 11, 2024

✅ Pull request refreshed

mazyu36 commented Sep 11, 2024

mergify bot commented Sep 11, 2024

❌ Command disallowed due to command restrictions in the Mergify configuration.

mazyu36 commented Sep 13, 2024

mergify bot commented Sep 13, 2024

✅ Branch has been successfully updated

mazyu36 commented Sep 13, 2024

mergify bot commented Sep 13, 2024

✅ Pull request refreshed

mergify bot commented Sep 13, 2024

aws-cdk-automation commented Sep 13, 2024

AWS CodeBuild CI Report

mergify bot commented Sep 13, 2024

github-actions bot commented Sep 13, 2024

mazyu36 commented May 17, 2024 •

edited

Loading

pahud left a comment •

edited

Loading